Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2296723006: Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows Can't just let the GC collect the pool on Windows. R=tandrii@chromium.org BUG=618726 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6

Patch Set 1 #

Patch Set 2 : mock something something #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M presubmit_support.py View 2 chunks +7 lines, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
scottmg
4 years, 3 months ago (2016-08-31 21:02:58 UTC) #2
tandrii(chromium)
awesome, LGTM!
4 years, 3 months ago (2016-09-01 15:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296723006/1
4 years, 3 months ago (2016-09-01 15:50:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30ff438ede6b4510)
4 years, 3 months ago (2016-09-01 15:56:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296723006/20001
4 years, 3 months ago (2016-09-01 16:08:57 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 16:16:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/86099d7ce5d1e1...

Powered by Google App Engine
This is Rietveld 408576698