Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 22967005: Properly measure usage for Node attributes removed from DOM4 (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use
Visibility:
Public.

Description

Properly measure usage for Node attributes removed from DOM4 The following Node attributes were removed from DOM4: - namespaceURI - localName - prefix However, those attributes were moved to Element and Attr in DOM4. Therefore, we only want to measure usage of those attributes for other types than Element and Attr to minimize the noise. To address this issue, corresponding attributes were added to Element and Attr interfaces so that those are used in priority for Elements and Attribute nodes, and not the corresponding Node bindings code whose usage is being measured. R=arv BUG=272149 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M Source/core/dom/Attr.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
Is this OK? Otherwise, we should get rid of the MeasureAs since there will be ...
7 years, 4 months ago (2013-08-16 13:49:36 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-16 14:24:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22967005/1
7 years, 4 months ago (2013-08-16 18:49:46 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 20:07:09 UTC) #4
Message was sent while issue was closed.
Change committed as 156241

Powered by Google App Engine
This is Rietveld 408576698