Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2296693003: Don't RAF align touch moves that are blocking. (Closed)

Created:
4 years, 3 months ago by dtapuska
Modified:
4 years, 3 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't RAF align touch moves that are blocking. It doesn't make sense to wait arbitrary for touch events that are blocking. So make them appear as non-continuous events. BUG=625693 Committed: https://crrev.com/bcdbb3fba1e0cebab4757384fde69d909295622c Cr-Commit-Position: refs/heads/master@{#415639}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M content/renderer/input/main_thread_event_queue.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 4 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
dtapuska
4 years, 3 months ago (2016-08-30 18:11:03 UTC) #4
tdresser
LGTM https://codereview.chromium.org/2296693003/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2296693003/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode28 content/renderer/input/main_thread_event_queue.cc:28: case blink::WebInputEvent::TouchMove: Add a comment on why we're ...
4 years, 3 months ago (2016-08-31 13:23:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296693003/20001
4 years, 3 months ago (2016-08-31 13:42:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 15:34:02 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 15:36:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bcdbb3fba1e0cebab4757384fde69d909295622c
Cr-Commit-Position: refs/heads/master@{#415639}

Powered by Google App Engine
This is Rietveld 408576698