Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2296683004: Revert of SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. (patchset #3 id:40001 of https://codereview.chromium.org/2258233002/ ) Reason for revert: forgot to roll sfntly in android! Original issue's description: > SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. > > Also, minor code refactoring. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 > > Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f TBR=bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8e3f54d51930f0c2f3bebf163ee7754b69080ae8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -68 lines) Patch
M src/pdf/SkPDFFont.cpp View 3 chunks +86 lines, -68 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hal.canary
Created Revert of SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName.
4 years, 3 months ago (2016-08-30 18:58:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296683004/1
4 years, 3 months ago (2016-08-30 18:58:48 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:58:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e3f54d51930f0c2f3bebf163ee7754b69080ae8

Powered by Google App Engine
This is Rietveld 408576698