Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2296663002: Add a test for adoptedCallback for custom elements in imports (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
Reviewers:
kojii
CC:
blink-reviews, chromium-reviews, davaajav, dominicc (has gone to gerrit), tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for adoptedCallback for custom elements in imports BUG=594918 Committed: https://crrev.com/8f1ba39a2ce5eb319a070461aa812fc3ff17684b Cr-Commit-Position: refs/heads/master@{#416879}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : Add document->import move test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/custom-elements/imports/adopted-callback.html View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/custom-elements/imports/resources/adopted-nodes.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kochi
Koji-san, Could you take a look? We already have a test for attributeChangedCallback, and will ...
4 years, 3 months ago (2016-09-07 06:17:15 UTC) #4
kojii
lgtm
4 years, 3 months ago (2016-09-07 06:50:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296663002/40001
4 years, 3 months ago (2016-09-07 07:18:57 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 08:06:33 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 08:08:40 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f1ba39a2ce5eb319a070461aa812fc3ff17684b
Cr-Commit-Position: refs/heads/master@{#416879}

Powered by Google App Engine
This is Rietveld 408576698