Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2296653002: Keeps the opt-in IME menu in lock screen. (Closed)

Created:
4 years, 3 months ago by Azure Wei
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, achuith+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

The opt-in IME menu was implemented with panel in shelf, which could not show in lock screen. Thus, the menu changed back the system menu. Since now the opt-in IME menu is created with native views on tray, we don't need to change back to system menu in lock screen. When switching users, the opt-in IME menu could not get preferences change event to update the menu activation state. This cl also fix this issue by saving the state by profile in InputMethodManager and sending the event of switching active user. TBR=shuchen@chromium.org NOPRESUBMIT=true NOTRY=true BUG=640266 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2274013003 Cr-Commit-Position: refs/heads/master@{#414988} (cherry picked from commit 47a06020c728d53c5f3c900234f7b6def397816a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/chromeos/input_method_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296653002/1
4 years, 3 months ago (2016-08-30 08:58:35 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 08:59:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698