Use shell=False on non-Windows for gn-format.py

Use shell=False on non-Windows for gn-format.py

I don't exactly know why, but it wouldn't work for me on Mac with
shell=True. (I guess there must be few users other than me as no one
else noticed I guess.)

R=thakis@chromium.org

Committed: https://crrev.com/38182d4aa014f32cb1298a230514dea181b1b1c0
Cr-Commit-Position: refs/heads/master@{#415416}

[scottmg, 2016-08-30 19:23:32]

Description was changed from

==========
Use shell=False on non-Windows for gn-format.py

R=thakis@chromium.org
==========

to

==========
Use shell=False on non-Windows for gn-format.py

I don't exactly know why, but it wouldn't work for me on Mac with
shell=True. (I guess there must be few users other than me.)

R=thakis@chromium.org
==========

[scottmg, 2016-08-30 19:23:54]

Description was changed from

==========
Use shell=False on non-Windows for gn-format.py

I don't exactly know why, but it wouldn't work for me on Mac with
shell=True. (I guess there must be few users other than me.)

R=thakis@chromium.org
==========

to

==========
Use shell=False on non-Windows for gn-format.py

I don't exactly know why, but it wouldn't work for me on Mac with
shell=True. (I guess there must be few users other than me as no one
else noticed I guess.)

R=thakis@chromium.org
==========

[scottmg, 2016-08-30 19:24:20]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:25:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-08-30 19:33:47]

lgtm

Maybe add a comment explaining that the shell=True is needed on Windows due to
gn.bat shenanigans (assuming that's the reason)

Nice, I had no idea we had this script :-)

[Nico, 2016-08-30 19:34:31]

(Maybe tools/vim/clang-format.vim should bind the formatting key therein to this
script for .gn files?)

[scottmg, 2016-08-30 19:36:09]

On 2016/08/30 19:33:47, Nico wrote:
> lgtm
> 
> Maybe add a comment explaining that the shell=True is needed on Windows due to
> gn.bat shenanigans (assuming that's the reason)

Done.

> 
> Nice, I had no idea we had this script :-)

[scottmg, 2016-08-30 19:37:52]

On 2016/08/30 19:34:31, Nico wrote:
> (Maybe tools/vim/clang-format.vim should bind the formatting key therein to
this
> script for .gn files?)

Heh, I didn't know we had that script. :)

I guess the hard part is picking a key. I use the same key with 

au BufRead,BufNewFile,BufEnter *.c,*.cc,*.cpp,*.h ...
au BufRead,BufNewFile,BufEnter *.gn,*.gni ...

to switch it between gn-format and clang-format depending on file type.

[scottmg, 2016-08-30 19:38:10]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-08-30 19:38:11]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2296633003/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-08-30 19:38:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:39:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 20:42:36]

Description was changed from

==========
Use shell=False on non-Windows for gn-format.py

I don't exactly know why, but it wouldn't work for me on Mac with
shell=True. (I guess there must be few users other than me as no one
else noticed I guess.)

R=thakis@chromium.org
==========

to

==========
Use shell=False on non-Windows for gn-format.py

I don't exactly know why, but it wouldn't work for me on Mac with
shell=True. (I guess there must be few users other than me as no one
else noticed I guess.)

R=thakis@chromium.org

Committed: https://crrev.com/38182d4aa014f32cb1298a230514dea181b1b1c0
Cr-Commit-Position: refs/heads/master@{#415416}
==========

[commit-bot: I haz the power, 2016-08-30 20:42:37]

Patchset 2 (id:??) landed as
https://crrev.com/38182d4aa014f32cb1298a230514dea181b1b1c0
Cr-Commit-Position: refs/heads/master@{#415416}