chrome/common/importer/mock_importer_bridge.h - Issue 2296633002: Fix Firefox bookmarks import.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/importer/mock_importer_bridge.h

Issue 2296633002: Fix Firefox bookmarks import. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed references to firefox_places.{cc,h} Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	Ilya Sherman 2016/10/26 22:55:59 nit: Please omit "(c)" from this line. nit: Please omit "(c)" from this line. kszatan 2016/11/02 08:17:34 Done. Show quoted text On 2016/10/26 22:55:59, Ilya Sherman wrote: > nit: Please omit "(c)" from this line. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_IMPORTER_MOCK_IMPORTER_BRIDGE_H_

	6 #define CHROME_COMMON_IMPORTER_MOCK_IMPORTER_BRIDGE_H_

	7

	8 #include <string>

	9 #include <vector>

	10

	11 #include "chrome/common/importer/imported_bookmark_entry.h"

	12 #include "chrome/common/importer/importer_autofill_form_data_entry.h"

	13 #include "chrome/common/importer/importer_bridge.h"

	14 #include "components/autofill/core/common/password_form.h"

	15 #include "testing/gmock/include/gmock/gmock.h"

	16

	17 class MockImporterBridge : public ImporterBridge {

	18 public:

	19 MOCK_METHOD2(AddBookmarks,

	20 void(const std::vector<ImportedBookmarkEntry>&,

	21 const base::string16&));

	22 MOCK_METHOD1(AddHomePage, void(const GURL&));

	23 #if defined(OS_WIN)

	24 MOCK_METHOD1(AddIE7PasswordInfo,

	25 void(const importer::ImporterIE7PasswordInfo&));

	26 #endif

	27 MOCK_METHOD1(SetFavicons, void(const favicon_base::FaviconUsageDataList&));

	28 MOCK_METHOD2(SetHistoryItems,

	29 void(const std::vector<ImporterURLRow>&, importer::VisitSource));

	30 MOCK_METHOD2(SetKeywords,

	31 void(const std::vector<importer::SearchEngineInfo>&, bool));

	32 MOCK_METHOD1(SetFirefoxSearchEnginesXMLData,

	33 void(const std::vector<std::string>&));

	34 MOCK_METHOD1(SetPasswordForm, void(const autofill::PasswordForm&));

	35 MOCK_METHOD1(SetAutofillFormData,

	36 void(const std::vector<ImporterAutofillFormDataEntry>&));

	37 MOCK_METHOD0(NotifyStarted, void());

	38 MOCK_METHOD1(NotifyItemStarted, void(importer::ImportItem));

	39 MOCK_METHOD1(NotifyItemEnded, void(importer::ImportItem));

	40 MOCK_METHOD0(NotifyEnded, void());

	41 MOCK_METHOD1(GetLocalizedString, base::string16(int));

	42

	43 std::vector<ImportedBookmarkEntry> bookmarks;

	44 favicon_base::FaviconUsageDataList favicons;

	45 std::vector<ImporterURLRow> history;
	Ilya Sherman 2016/10/26 22:55:59 Hmm, where are these three lines used? It looks l Hmm, where are these three lines used? It looks like these could easily be local variables in tests, rather than part of the mock header's interface. kszatan 2016/11/02 08:17:34 Done. Show quoted text On 2016/10/26 22:55:59, Ilya Sherman wrote: > Hmm, where are these three lines used? It looks like these could easily be > local variables in tests, rather than part of the mock header's interface. Done.
	46

	47 private:

	48 ~MockImporterBridge() override;

	49 };

	50

	51 #endif // CHROME_COMMON_IMPORTER_MOCK_IMPORTER_BRIDGE_H_

OLD	NEW

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/importer/mock_importer_bridge.cc » ('j') | chrome/utility/importer/firefox_importer_unittest.cc » ('J')