Fix the wrong candidate window on Mac OSX.

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import <objc/runtime.h>
 #include <OpenGL/gl.h>
 #include <QuartzCore/QuartzCore.h>
 #include <stdint.h>
@@ skipping 856 matching lines @@
   // like Chrome does on Windows, call |UpdateCursor()| here.
 }
 
 void RenderWidgetHostViewMac::OnUpdateTextInputStateCalled(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view,
     bool did_update_state) {
   if (!did_update_state)
     return;
 
+  // Set the monitor state based on the text input focus state.
+  RenderWidgetHost* host = GetRenderWidgetHost();

[Alexei Svitkine (slow), 2016/09/02 15:48:05]

Nit: Remove this line and just inline render_widget_host_->GetRoutingID() into
the IPC ctor.

[Seigo Nonaka, 2016/09/07 23:53:38]

Done.

+  const TextInputState* state = text_input_manager->GetTextInputState();
+  bool need_monitor_composition =
+    HasFocus() && state && state->type != ui::TEXT_INPUT_TYPE_NONE;

[Alexei Svitkine (slow), 2016/09/02 15:48:05]

Nit: Wrong indent, maybe just run git cl format?

[Seigo Nonaka, 2016/09/07 23:53:38]

Ah yes, sorry I ran git cl format for the latest patch.
Thank you.

+  Send(new InputMsg_RequestCompositionUpdate(host->GetRoutingID(),
+            false /* immediate request */, need_monitor_composition));
+
   if (HasFocus()) {

[Alexei Svitkine (slow), 2016/09/02 15:48:05]

You're adding another call to HasFocus(). Please only call it once and move the
result in a local var.

[Seigo Nonaka, 2016/09/07 23:53:38]

Done.

     SetTextInputActive(true);
 
     // Let AppKit cache the new input context to make IMEs happy.
     // See http://crbug.com/73039.
     [NSApp updateWindows];
 
 #ifndef __LP64__
     bool can_compose_inline =
         !!GetTextInputManager()->GetActiveWidget()
             ? GetTextInputManager()->GetTextInputState()->can_compose_inline
             : true;
     UseInputWindow(TSMGetActiveDocument(), !can_compose_inline);
 #endif
   }
 }
 
 void RenderWidgetHostViewMac::OnImeCancelComposition(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view) {
   [cocoa_view_ cancelComposition];
 }
 
 void RenderWidgetHostViewMac::OnImeCompositionRangeChanged(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view) {
   const TextInputManager::CompositionRangeInfo* info =
       GetTextInputManager()->GetCompositionRangeInfo();
+  if (!info)

[Seigo Nonaka, 2016/09/02 02:18:04]

This is now necessary since GetCompositionRangeInfo can return nullptr.
This typically happens on browser tests.

+    return;
   // The RangeChanged message is only sent with valid values. The current
   // caret position (start == end) will be sent if there is no IME range.
   [cocoa_view_ setMarkedRange:info->range.ToNSRange()];
   composition_range_ = info->range;
   composition_bounds_ = info->character_bounds;
 }
 
 void RenderWidgetHostViewMac::OnTextSelectionChanged(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view) {
@@ skipping 2346 matching lines @@
 
 // "-webkit-app-region: drag | no-drag" is implemented on Mac by excluding
 // regions that are not draggable. (See ControlRegionView in
 // native_app_window_cocoa.mm). This requires the render host view to be
 // draggable by default.
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
 
 @end