Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2296603002: Enable NonValidatingReloadOnRefreshContentV2 feature by default (Closed)

Created:
4 years, 3 months ago by Takashi Toyoshima
Modified:
4 years, 3 months ago
Reviewers:
no sievers
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NonValidatingReloadOnRefreshContentV2 feature by default Now the feature is approved to roll out into Stable channel, let me flip the feature flag to be enabled by default. This is a required process to launch the feature through the field study, and should be done before the feature is rolled out to 100%. BUG=591245 Committed: https://crrev.com/7028d835148f418a727954ee3f5cb88a6c820dcd Cr-Commit-Position: refs/heads/master@{#415569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Takashi Toyoshima
Can you take a look?
4 years, 3 months ago (2016-08-30 07:29:29 UTC) #3
no sievers
lgtm
4 years, 3 months ago (2016-08-30 21:57:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296603002/1
4 years, 3 months ago (2016-08-31 03:36:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/133519)
4 years, 3 months ago (2016-08-31 03:55:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296603002/1
4 years, 3 months ago (2016-08-31 05:09:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 05:42:15 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:43:39 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7028d835148f418a727954ee3f5cb88a6c820dcd
Cr-Commit-Position: refs/heads/master@{#415569}

Powered by Google App Engine
This is Rietveld 408576698