Call RecordLastRunAppBundlePath in FILE thread

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "apps/shell_window_registry.h"
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 147 matching lines @@
 }
 
 // Record the location of the application bundle (containing the main framework)
 // from which Chromium was loaded. This is used by app mode shims to find
 // Chromium.
 void RecordLastRunAppBundlePath() {
   // Going up three levels from |chrome::GetVersionedDirectory()| gives the
   // real, user-visible app bundle directory. (The alternatives give either the
   // framework's path or the initial app's path, which may be an app mode shim
   // or a unit test.)
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+
   base::FilePath appBundlePath =
       chrome::GetVersionedDirectory().DirName().DirName().DirName();

[tapted, 2013/08/22 23:28:04]

drive-by: Is there an issue down the code path

GetVersionedDirectory()
 -> IsBackgroundOnlyProcess()
  ->  [NSBundle infoDictionary]

NSBundle isn't threadsafe according to most sources. But this is just reading
from the plist. If it's a problem, the return value from
base::mac::IsBackgroundOnlyProcess() could be fed through from the UI thread.

   CFPreferencesSetAppValue(
       base::mac::NSToCFCast(app_mode::kLastRunAppBundlePathPrefsKey),
       base::SysUTF8ToCFStringRef(appBundlePath.value()),
       BaseBundleID_CFString());
 
-  // Sync after a delay avoid I/O contention on startup; 1500 ms is plenty.
-  BrowserThread::PostDelayedTask(
-      BrowserThread::FILE, FROM_HERE,
-      base::Bind(&PrefsSyncCallback),
-      base::TimeDelta::FromMilliseconds(1500));
+  PrefsSyncCallback();
 }
 
 }  // anonymous namespace
 
 @interface AppController (Private)
 - (void)initMenuState;
 - (void)initProfileMenu;
 - (void)updateConfirmToQuitPrefMenuItem:(NSMenuItem*)item;
 - (void)registerServicesMenuTypesTo:(NSApplication*)app;
 - (void)openUrls:(const std::vector<GURL>&)urls;
@@ skipping 474 matching lines @@
   // Instantiate the ProfileInfoCache observer so that we can get
   // notified when a profile is deleted.
   profileInfoCacheObserver_.reset(new AppControllerProfileObserver(
       g_browser_process->profile_manager(), self));
 
   // Since Chrome is localized to more languages than the OS, tell Cocoa which
   // menu is the Help so it can add the search item to it.
   [NSApp setHelpMenu:helpMenu_];
 
   // Record the path to the (browser) app bundle; this is used by the app mode
-  // shim.
-  RecordLastRunAppBundlePath();
+  // shim. Sync after a delay avoid I/O contention on startup; 1500 ms is
+  // plenty.
+  BrowserThread::PostDelayedTask(
+      BrowserThread::FILE, FROM_HERE,
+      base::Bind(&RecordLastRunAppBundlePath),
+      base::TimeDelta::FromMilliseconds(1500));
 
   // Makes "Services" menu items available.
   [self registerServicesMenuTypesTo:[notify object]];
 
   startupComplete_ = YES;
 
   // TODO(viettrungluu): This is very temporary, since this should be done "in"
   // |BrowserMain()|, i.e., this list of startup URLs should be appended to the
   // (probably-empty) list of URLs from the command line.
   if (startupUrls_.size()) {
@@ skipping 732 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac