Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2296593002: [turbofan] Sanitize typing of Date builtins. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Sanitize typing of Date builtins. Put the types for the Date builtins into the TypeCache, and add support for Date.prototype.getDay and Date.prototype.getMinutes. R=epertoso@chromium.org BUG=v8:5267 Committed: https://crrev.com/9bdce030df73681e5f5fc28b4b2b2b349d283c57 Cr-Commit-Position: refs/heads/master@{#39005}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -13 lines) Patch
M src/compiler/type-cache.h View 1 1 chunk +35 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-30 06:35:41 UTC) #1
epertoso
lgtm https://codereview.chromium.org/2296593002/diff/1/src/compiler/type-cache.h File src/compiler/type-cache.h (right): https://codereview.chromium.org/2296593002/diff/1/src/compiler/type-cache.h#newcode108 src/compiler/type-cache.h:108: // [0, 23] or NaN. [1, 31]
4 years, 3 months ago (2016-08-30 08:08:04 UTC) #10
Benedikt Meurer
https://codereview.chromium.org/2296593002/diff/1/src/compiler/type-cache.h File src/compiler/type-cache.h (right): https://codereview.chromium.org/2296593002/diff/1/src/compiler/type-cache.h#newcode108 src/compiler/type-cache.h:108: // [0, 23] or NaN. On 2016/08/30 08:08:04, epertoso ...
4 years, 3 months ago (2016-08-30 09:35:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296593002/20001
4 years, 3 months ago (2016-08-30 09:36:15 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 10:05:48 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 10:06:25 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bdce030df73681e5f5fc28b4b2b2b349d283c57
Cr-Commit-Position: refs/heads/master@{#39005}

Powered by Google App Engine
This is Rietveld 408576698