third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp - Issue 2296573003: binding: Reduces the binary size of binding's generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Issue 2296573003: binding: Reduces the binary size of binding's generated code. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

index 6ebddc468892fe31fd69ae455b691b92a7d075d8..ef1c905755ecb922bb978658e43166c1c0612e5b 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

@@ -414,6 +414,7 @@ void V8TestInterfacePartial::installOriginTrialPartialFeature(ScriptState* scrip

}

void V8TestInterfacePartial::preparePrototypeAndInterfaceObject(v8::Local<v8::Context> context, const DOMWrapperWorld& world, v8::Local<v8::Object> prototypeObject, v8::Local<v8::Function> interfaceObject, v8::Local<v8::FunctionTemplate> interfaceTemplate)

{

+#error No one is currently using a partial interface with context-dependent properties. If you\'re planning to use it, please consult with the binding team: <blink-reviews-bindings@chromium.org>

V8TestInterface::preparePrototypeAndInterfaceObject(context, world, prototypeObject, interfaceObject, interfaceTemplate);

v8::Isolate* isolate = context->GetIsolate();

v8::Local<v8::Name> unscopablesSymbol(v8::Symbol::GetUnscopables(isolate));

@@ -431,7 +432,7 @@ void V8TestInterfacePartial::initialize()

// Should be invoked from ModulesInitializer.

V8TestInterface::updateWrapperTypeInfo(

&V8TestInterfacePartial::installV8TestInterfaceTemplate,

- &V8TestInterfacePartial::preparePrototypeAndInterfaceObject);

+ V8TestInterfacePartial::preparePrototypeAndInterfaceObject);

V8TestInterface::registerVoidMethodPartialOverloadMethodForPartialInterface(&TestInterfaceImplementationPartialV8Internal::voidMethodPartialOverloadMethod);

V8TestInterface::registerStaticVoidMethodPartialOverloadMethodForPartialInterface(&TestInterfaceImplementationPartialV8Internal::staticVoidMethodPartialOverloadMethod);

V8TestInterface::registerPromiseMethodPartialOverloadMethodForPartialInterface(&TestInterfaceImplementationPartialV8Internal::promiseMethodPartialOverloadMethod);