Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/metrics/metrics_service.h

Issue 2296543002: Quantify initial stability report edge cases. (Closed)
Patch Set: Fix unittests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/metrics/metrics_log.cc ('K') | « components/metrics/metrics_pref_names.cc ('k') | components/metrics/metrics_service.cc » ('j') | components/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_service.h
diff --git a/components/metrics/metrics_service.h b/components/metrics/metrics_service.h
index 36aeba19a423c1badc784bd3ae3a5cc02238417f..69bbd0208f6144e96f383f00df2e4dcfadafecb4 100644
--- a/components/metrics/metrics_service.h
+++ b/components/metrics/metrics_service.h
@@ -354,7 +354,7 @@ class MetricsService : public base::HistogramFlattener {
// from that previous run, and only these stability metrics. It uses the
// system profile from the previous session. Returns true if a log was
// created.
- bool PrepareInitialStabilityLog();
+ bool PrepareInitialStabilityLog(const std::string& prefs_previous_version);
Alexei Svitkine (slow) 2016/09/02 17:57:49 Nit: Document this parameter in the comment.
manzagop (departed) 2016/09/02 21:00:06 Done.
// Prepares the initial metrics log, which includes startup histograms and
// profiler data, as well as incremental stability-related metrics.
« components/metrics/metrics_log.cc ('K') | « components/metrics/metrics_pref_names.cc ('k') | components/metrics/metrics_service.cc » ('j') | components/metrics/metrics_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698