Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2447)

Unified Diff: components/metrics/metrics_log.h

Issue 2296543002: Quantify initial stability report edge cases. (Closed)
Patch Set: Change a metric's name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_macros.h ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log.h
diff --git a/components/metrics/metrics_log.h b/components/metrics/metrics_log.h
index 0506df28db095d2f41f1d181c905e119da933ea7..6b37e7b4c9805ae535c014939703e965a791f397 100644
--- a/components/metrics/metrics_log.h
+++ b/components/metrics/metrics_log.h
@@ -100,9 +100,11 @@ class MetricsLog {
int64_t metrics_reporting_enabled_date);
// Loads the environment proto that was saved by the last RecordEnvironment()
- // call from prefs and clears the pref value. Returns true on success or false
- // if there was no saved environment in prefs or it could not be decoded.
- bool LoadSavedEnvironmentFromPrefs();
+ // call from prefs and clears the pref value. On success, returns true and
+ // |app_version| contains the recovered version. Otherwise (if there was no
+ // saved environment in prefs or it could not be decoded), returns false and
+ // |app_version| is empty.
+ bool LoadSavedEnvironmentFromPrefs(std::string* app_version);
// Writes application stability metrics, including stability metrics provided
// by the specified set of |metrics_providers|. The system profile portion of
« no previous file with comments | « base/metrics/histogram_macros.h ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698