Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2296503003: Fix parsing of exponents in StringToDouble. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix parsing of exponents in StringToDouble. BUG=542881 Committed: https://crrev.com/079cdc8e1483c42d5318a02bd300670cc5b7d477 Cr-Commit-Position: refs/heads/master@{#416158}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : comments, more test cases #

Patch Set 4 : better comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M base/strings/string_number_conversions_unittest.cc View 1 2 3 2 chunks +34 lines, -0 lines 0 comments Download
M base/third_party/dmg_fp/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M base/third_party/dmg_fp/dtoa.cc View 1 chunk +4 lines, -1 line 0 comments Download
A base/third_party/dmg_fp/exp_length.patch View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Lei Zhang
4 years, 3 months ago (2016-08-30 04:19:45 UTC) #6
Lei Zhang
ping ping
4 years, 3 months ago (2016-08-31 05:36:38 UTC) #7
Lei Zhang
chirp chirp chirp
4 years, 3 months ago (2016-09-01 23:01:19 UTC) #9
danakj
LGTM https://codereview.chromium.org/2296503003/diff/1/base/strings/string_number_conversions_unittest.cc File base/strings/string_number_conversions_unittest.cc (right): https://codereview.chromium.org/2296503003/diff/1/base/strings/string_number_conversions_unittest.cc#newcode732 base/strings/string_number_conversions_unittest.cc:732: {"1.7976e308", 1.7976e308, true}, Can you drop a comment ...
4 years, 3 months ago (2016-09-01 23:49:24 UTC) #10
Lei Zhang
https://codereview.chromium.org/2296503003/diff/1/base/strings/string_number_conversions_unittest.cc File base/strings/string_number_conversions_unittest.cc (right): https://codereview.chromium.org/2296503003/diff/1/base/strings/string_number_conversions_unittest.cc#newcode732 base/strings/string_number_conversions_unittest.cc:732: {"1.7976e308", 1.7976e308, true}, On 2016/09/01 23:49:23, danakj wrote: > ...
4 years, 3 months ago (2016-09-02 01:07:10 UTC) #13
danakj
Thanks :) LGTM
4 years, 3 months ago (2016-09-02 01:09:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296503003/60001
4 years, 3 months ago (2016-09-02 01:41:22 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 01:46:31 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 01:48:39 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/079cdc8e1483c42d5318a02bd300670cc5b7d477
Cr-Commit-Position: refs/heads/master@{#416158}

Powered by Google App Engine
This is Rietveld 408576698