Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4166)

Unified Diff: chrome/common/variations/BUILD.gn

Issue 2296493002: Merge all Field Trial Testing Configuration Together (Closed)
Patch Set: Review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/variations/PRESUBMIT.py » ('j') | testing/variations/PRESUBMIT.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/variations/BUILD.gn
diff --git a/chrome/common/variations/BUILD.gn b/chrome/common/variations/BUILD.gn
index 8a539761949457dc67e25d1608a323041ae92629..b38c17b95f657d2a486a10e91991f411ecb333a5 100644
--- a/chrome/common/variations/BUILD.gn
+++ b/chrome/common/variations/BUILD.gn
@@ -7,24 +7,26 @@ action("fieldtrial_testing_config_action") {
script = "//tools/variations/fieldtrial_to_struct.py"
if (is_win) {
- source = "//testing/variations/fieldtrial_testing_config_win.json"
+ platform = "win"
}
if (is_mac) {
- source = "//testing/variations/fieldtrial_testing_config_mac.json"
+ platform = "mac"
}
if (is_linux) {
- source = "//testing/variations/fieldtrial_testing_config_linux.json"
+ platform = "linux"
}
if (is_chromeos) {
- source = "//testing/variations/fieldtrial_testing_config_chromeos.json"
+ platform = "chromeos"
}
if (is_android) {
- source = "//testing/variations/fieldtrial_testing_config_android.json"
+ platform = "android"
}
if (is_ios) {
- source = "//testing/variations/fieldtrial_testing_config_ios.json"
+ platform = "ios"
}
+ source = "//testing/variations/fieldtrial_testing_config.json"
Alexei Svitkine (slow) 2016/08/30 17:59:15 Nit: Just inline this on line 34
robliao 2016/08/30 18:16:43 This is also used in line 43.
+
inputs = [
"//tools/json_to_struct/element_generator.py",
"//tools/json_to_struct/json_to_struct.py",
@@ -43,6 +45,7 @@ action("fieldtrial_testing_config_action") {
"--namespace=chrome_variations",
"--schema=" +
rebase_path("fieldtrial_testing_config_schema.json", root_build_dir),
+ "--platform=" + platform,
"--output=$out_name",
]
}
« no previous file with comments | « no previous file | testing/variations/PRESUBMIT.py » ('j') | testing/variations/PRESUBMIT.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698