Merge all Field Trial Testing Configuration Together

testing/variations/PRESUBMIT.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Presubmit script validating field trial configs.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details on the presubmit API built into depot_tools.
 """
 
 import json
@@ skipping 26 matching lines @@
     message_type: Type of message from |output_api| to return in the case of
         errors/warnings.
 
   Returns:
     A list of |message_type| messages. In the case of all tests passing with no
     warnings/errors, this will return [].
   """
   if not isinstance(json_data, dict):
     return [message_type(
         'Malformed config file %s: Expecting dict' % file_path)]
-  for (study, groups) in json_data.iteritems():
-    if not isinstance(study, unicode):
+  for (trial, group_configs) in json_data.iteritems():
+    if not isinstance(trial, unicode):
       return [message_type(
-          'Malformed config file %s: Expecting keys to be string, got %s'
-          % (file_path, type(study)))]
-    if not isinstance(groups, list):
+          'Malformed config file %s: Expecting keys to be string, got %s' %
+              (file_path, type(trial)))]
+    if not isinstance(group_configs, list):
       return [message_type(
-          'Malformed config file %s: Expecting list for study %s'
-          % (file_path, study))]
-    for group in groups:
-      if not isinstance(group, dict):
+          'Malformed config file %s: Expecting list for trial %s' % (file_path,
+                                                                     trial))]
+    for group_config in group_configs:
+      if not isinstance(group_config, dict):
+        return [message_type('Malformed config file %s: Expecting dict for '
+            'group config in Trial[%s]' % (file_path, trial))]
+      if not 'groups' in group_config:
         return [message_type(
-            'Malformed config file %s: Expecting dict for group in '
-            'Study[%s]' % (file_path, study))]
-      if not 'group_name' in group or not isinstance(group['group_name'],
-          unicode):
-        return [message_type(
-            'Malformed config file %s: Missing valid group_name for group'
-            ' in Study[%s]' % (file_path, study))]
-      if 'params' in group:
-        params = group['params']
-        if not isinstance(params, dict):
+            'Malformed config file %s: Missing valid groups for group config '
+                'in Trial[%s]' % (file_path, trial))]
+      if not isinstance(group_config['groups'], list):
+        return [message_type('Malformed config file %s: Expecting list for '
+            'groups in Trial[%s]' % (file_path, trial))]

[Alexei Svitkine (slow), 2016/08/31 20:17:27]

Nit: There's a bunch of repetition in these messages. Can you make a helper
function?

The "Malformed config file %s: " + msg + " in Trial[%s]" is common to all these.

[robliao, 2016/09/01 21:49:07]

Done.

+      for group in group_config['groups']:
+        if not 'group_name' in group or not isinstance(group['group_name'],
+                                                       unicode):
           return [message_type(
-              'Malformed config file %s: Invalid params for Group[%s]'
-              ' in Study[%s]' % (file_path, group['group_name'],
-              study))]
-        for (key, value) in params.iteritems():
-          if not isinstance(key, unicode) or not isinstance(value,
-              unicode):
+              'Malformed config file %s: Missing valid group_name for group in '
+                  'Trial[%s]' % (file_path, trial))]
+        if 'params' in group:
+          params = group['params']
+          if not isinstance(params, dict):
             return [message_type(
-                'Malformed config file %s: Invalid params for Group[%s]'
-                ' in Study[%s]' % (file_path, group['group_name'],
-                study))]
-      for key in group.keys():
-        if key not in VALID_GROUP_KEYS:
-          return [message_type(
-              'Malformed config file %s: Key[%s] in Group[%s] in Study[%s] '
-              'is not a valid key.' % (
-                  file_path, key, group['group_name'], study))]
+                'Malformed config file %s: Invalid params for Group[%s] in '
+                'Trial[%s]' % (file_path, group['group_name'], trial))]
+          for (key, value) in params.iteritems():
+            if not isinstance(key, unicode) or not isinstance(value, unicode):
+              return [message_type('Malformed config file %s: Invalid params '
+                  'for Group[%s] in Study[%s]' % (file_path,
+                                                  group['group_name'], trial))]
+        for key in group.keys():
+          if key not in VALID_GROUP_KEYS:
+            return [message_type(
+                'Malformed config file %s: Key[%s] in Group[%s] in Trial[%s] '
+                    'is not a valid key.' % (file_path, key,
+                                             group['group_name'], trial))]
+      if not 'platforms' in group_config:
+        return [message_type('Malformed config file %s: Missing valid '
+            'platforms for group config in Trial[%s]' % (file_path, trial))]
+      if not isinstance(group_config['platforms'], list):
+        return [message_type('Malformed config file %s: Expecting list for '
+            'platforms in Trial[%s]' % (file_path, trial))]
+      supported_platforms = ['android', 'chromeos', 'ios', 'linux', 'mac',
+                             'win']
+      unsupported_platforms = list(set(group_config['platforms']).difference(
+          supported_platforms))
+      if unsupported_platforms:
+        return [message_type('Malformed config file %s: Unsupported platforms '
+            '%s in Trial[%s]' % (file_path, unsupported_platforms, trial))]
 
   return []
 
 def CheckPretty(contents, file_path, message_type):
   """Validates the pretty printing of fieldtrial configuration.
 
   Args:
     contents: File contents as a string.
     file_path: String representing the path to the JSON file.
     message_type: Type of message from |output_api| to return in the case of
@@ skipping 37 matching lines @@
   return CommonChecks(input_api, output_api)
 
 
 def main(argv):
   content = open(argv[1]).read()
   pretty = PrettyPrint(content)
   open(argv[1],'w').write(pretty)
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv))