Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: content/public/test/test_renderer_host.h

Issue 2296483002: Fix some unit_tests under PlzNavigate (Closed)
Patch Set: more fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_renderer_host.h
diff --git a/content/public/test/test_renderer_host.h b/content/public/test/test_renderer_host.h
index 3a645cf51c92f2da3aae875fd2ba889c050eb873..58132cea67dc49cc83d0fcb8ccc2e2aa7562bb33 100644
--- a/content/public/test/test_renderer_host.h
+++ b/content/public/test/test_renderer_host.h
@@ -96,6 +96,15 @@ class RenderFrameHostTester {
// Simulates a navigation stopping in the RenderFrameHost.
virtual void SimulateNavigationStop() = 0;
+ // If we are doing a cross-site navigation, this simulates the current
+ // RenderFrameHost notifying that it has unloaded so the pending
clamy 2016/08/31 18:23:21 nit: s/it has unloaded/BeforeUnload has executed
scottmg 2016/08/31 19:01:47 Done.
+ // RenderFrameHost is resumed and can navigate. Note that for some synchronous
clamy 2016/08/31 18:23:21 The Note... sentence seems to belong to the PlzNav
scottmg 2016/08/31 19:01:46 Done.
+ // navigations (about:blank, javascript urls, etc.), no simulation of the
+ // network stack is required.
+ // PlzNavigate: This simulates a BeforeUnload ACK from the renderer, and the
+ // interaction with the IO thread up until the response is ready to commit.
+ virtual void PrepareForCommitIfNecessary() = 0;
+
// Calls OnDidCommitProvisionalLoad on the RenderFrameHost with the given
// information with various sets of parameters. These are helper functions for
// simulating the most common types of loads.

Powered by Google App Engine
This is Rietveld 408576698