Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2296473002: v8.gyp: Fix mips (big-endian) build. (Closed)

Created:
4 years, 3 months ago by akos.palfi.imgtec
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

v8.gyp: Fix mips (big-endian) build. Fixes the MIPS big-endian build after https://codereview.chromium.org/2276733002/ . BUG= Committed: https://crrev.com/cdab5ed6466e35c247db86ee277cb922d2f1d75a Cr-Commit-Position: refs/heads/master@{#38994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ofrobots
On 2016/08/29 22:53:00, akos.palfi.imgtec wrote: > mailto:akos.palfi@imgtec.com changed reviewers: > + mailto:machenbach@chromium.org, mailto:ofrobots@google.com Thanks for ...
4 years, 3 months ago (2016-08-30 00:50:19 UTC) #7
Michael Achenbach
lgtm
4 years, 3 months ago (2016-08-30 06:59:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296473002/1
4 years, 3 months ago (2016-08-30 06:59:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 07:01:18 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 07:01:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdab5ed6466e35c247db86ee277cb922d2f1d75a
Cr-Commit-Position: refs/heads/master@{#38994}

Powered by Google App Engine
This is Rietveld 408576698