[fuchsia] Fix build for new sysroot

[fuchsia] Fix build for new sysroot

Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/a55ead5775861b392301a71ca65b53e09f132752

[anmittal, 2016-08-29 21:47:55]

anmittal@google.com changed reviewers:
+ anmittal@google.com, jamesr@chromium.org

[jamesr, 2016-08-29 21:50:38]

Please make the patch description more descriptive, keeping in mind this is a
commit to the dart-lang/sdk repo which has changes for dart in many
environments.  You should say that this change is for the GN build for Fuchsia

[jamesr, 2016-08-29 21:51:09]

jamesr@chromium.org changed reviewers:
+ zra@google.com

[jamesr, 2016-08-29 21:51:10]

https://codereview.chromium.org/2296463002/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2296463002/diff/1/runtime/bin/BUILD.gn#newcod...
runtime/bin/BUILD.gn:572: "magenta",
please keep these alphabetical

https://codereview.chromium.org/2296463002/diff/1/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2296463002/diff/1/runtime/vm/BUILD.gn#newcode21
runtime/vm/BUILD.gn:21: "magenta",
this too

[anmittal, 2016-08-29 21:53:56]

https://codereview.chromium.org/2296463002/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2296463002/diff/1/runtime/bin/BUILD.gn#newcod...
runtime/bin/BUILD.gn:572: "magenta",
On 2016/08/29 21:51:10, jamesr wrote:
> please keep these alphabetical

Done.

https://codereview.chromium.org/2296463002/diff/1/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2296463002/diff/1/runtime/vm/BUILD.gn#newcode21
runtime/vm/BUILD.gn:21: "magenta",
On 2016/08/29 21:51:10, jamesr wrote:
> this too

Done.

[zra, 2016-08-29 21:56:12]

Yah, if you could prepend [fuchsia] to the description that should be enough to
avoid confusion.

[jamesr, 2016-08-29 21:56:26]

BTW you edit the description in this system by hitting the 'Edit' button in web
UI, not via editing the commit in git.

[anmittal, 2016-08-29 21:56:46]

Description was changed from

==========
Fix build for new sysroot

Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
==========

to

==========
Fix build for new sysroot

[fuchsia] Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
==========

[anmittal, 2016-08-29 21:56:57]

Description was changed from

==========
Fix build for new sysroot

[fuchsia] Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
==========

to

==========
[fuchsia] Fix build for new sysroot

Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
==========

[anmittal, 2016-08-29 21:57:44]

On 2016/08/29 21:56:26, jamesr wrote:
> BTW you edit the description in this system by hitting the 'Edit' button in
web
> UI, not via editing the commit in git.

oh yeah, learned that while working on chrome :p

[zra, 2016-08-29 22:02:41]

lgtm

[anmittal, 2016-08-29 22:02:50]

On 2016/08/29 21:56:12, zra wrote:
> Yah, if you could prepend [fuchsia] to the description that should be enough
to
> avoid confusion.

done

[jamesr, 2016-08-29 22:03:40]

I'll land this

[jamesr, 2016-08-29 22:07:51]

Description was changed from

==========
[fuchsia] Fix build for new sysroot

Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
==========

to

==========
[fuchsia] Fix build for new sysroot

Fixing build as various syscalls have moved out of runtime so it needs
to depend on lib-magenta

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a55ead5775861b392301a71ca65b53e09f132752
==========

[jamesr, 2016-08-29 22:07:53]

Committed patchset #2 (id:20001) manually as
a55ead5775861b392301a71ca65b53e09f132752 (presubmit successful).