Add NV12 buffer scanout support from exo to ozone.

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148
, b/31159410,b/29625228
TBR=sievers
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Committed: https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e
Cr-Original-Commit-Position: refs/heads/master@{#418096}
Cr-Commit-Position: refs/heads/master@{#420815}

[Daniele Castagna, 2016-08-29 20:58:28]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Daniele Castagna, 2016-08-29 20:58:30]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2016-08-29 21:16:15]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=31159410
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Daniele Castagna, 2016-08-29 21:17:24]

dcastagna@chromium.org changed reviewers:
+ posciak@chromium.org, reveman@chromium.org, wuchengli@chromium.org

[reveman, 2016-08-29 21:20:25]

lgtm after fixing the name of the DRM_FORMAT define

https://codereview.chromium.org/2296433002/diff/1/ui/ozone/gl/gl_image_ozone_...
File ui/ozone/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2296433002/diff/1/ui/ozone/gl/gl_image_ozone_...
ui/ozone/gl/gl_image_ozone_native_pixmap.cc:23: #define DRM_FORMAT_NV21
FOURCC('N', 'V', '1', '2')
s/DRM_FORMAT_NV21/DRM_FORMAT_NV12/

[commit-bot: I haz the power, 2016-08-29 21:31:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-29 21:47:59]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2016-08-29 21:49:07]

https://codereview.chromium.org/2296433002/diff/1/ui/ozone/gl/gl_image_ozone_...
File ui/ozone/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2296433002/diff/1/ui/ozone/gl/gl_image_ozone_...
ui/ozone/gl/gl_image_ozone_native_pixmap.cc:23: #define DRM_FORMAT_NV21
FOURCC('N', 'V', '1', '2')
On 2016/08/29 at 21:20:25, reveman wrote:
> s/DRM_FORMAT_NV21/DRM_FORMAT_NV12/

Done.

[Daniele Castagna, 2016-08-29 22:07:48]

dcastagna@chromium.org changed reviewers:
+ sievers@chromium.org, spang@chromium.org

[Daniele Castagna, 2016-08-29 22:07:48]

+spang for ui/ozone/gl/*
+sievers for gpu/command_buffer/service/*

[Daniele Castagna, 2016-08-29 22:10:48]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=31159410
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-08-30 02:20:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:43:53]

Dry run: This issue passed the CQ dry run.

[spang, 2016-08-30 18:00:50]

lgtm

[no sievers, 2016-08-30 20:12:04]

gpu lgtm w/nit

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1016: // TODO(dcastagna): Determine
this feature at runtime querying minigbm.
putting a bug number would be even better

[reveman, 2016-08-30 21:10:54]

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1017:
feature_flags_.chromium_image_ycbcr_420v = true;
drive-by: are we missing AddExtensionString("GL_CHROMIUM_ycbcr_420v_image")
here?

[Daniele Castagna, 2016-09-12 22:14:58]

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1016: // TODO(dcastagna): Determine
this feature at runtime querying minigbm.
On 2016/08/30 at 20:12:04, sievers (slow) wrote:
> putting a bug number would be even better

Done.

https://codereview.chromium.org/2296433002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1017:
feature_flags_.chromium_image_ycbcr_420v = true;
On 2016/08/30 at 21:10:54, reveman wrote:
> drive-by: are we missing AddExtensionString("GL_CHROMIUM_ycbcr_420v_image")
here?

Done.

[Daniele Castagna, 2016-09-12 22:15:04]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-09-12 22:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sievers@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2296433002/#ps40001
(title: "Add bug link and extension string.")

[commit-bot: I haz the power, 2016-09-12 22:15:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-12 22:20:00]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-12 23:15:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-12 23:18:09]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}
==========

[commit-bot: I haz the power, 2016-09-12 23:18:10]

Patchset 3 (id:??) landed as
https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}

[wuchengli, 2016-09-21 09:26:44]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2360453003/ by wuchengli@chromium.org.

The reason for reverting is: This broke YouTube, Hangout, and camera app on many
ChromeOS devices. The video was black. See http://crbug.com/648528..

[Daniele Castagna, 2016-09-22 21:27:14]

PTAL.

Claiming that chromium_image_ycbcr_420v capability is available on ARM devices
made SW decoding in chromium use ycbcr_420v for video frames.
ARM devices are currently not using native GMB but shared memory, that doesn't
support ycbcr_420v.

I removed the code that enabled the capability in feature_info.cc and just
changed the function IsGpuMemoryBufferFormatSupported
gpu_memory_buffer_support.cc that is used to determine if it's possible to
create an image with as specific format.

In this way we can create the image for the buffer coming from exo, but we won't
try to allocate a ycbcr_420v buffer in chromium.

[reveman, 2016-09-23 09:22:00]

lgtm

[reveman, 2016-09-23 09:22:10]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 09:22:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 09:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:36:54]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[no sievers, 2016-09-23 17:30:23]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}
==========

[no sievers, 2016-09-23 17:30:23]

sievers@chromium.org changed reviewers:
- sievers@chromium.org

[Daniele Castagna, 2016-09-23 22:06:19]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-09-23 22:06:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2296433002/#ps60001
(title: "Don't claim that image_ycbcr_420v is available.")

[commit-bot: I haz the power, 2016-09-23 22:07:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-23 22:16:24]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
TBR=sievers
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}
==========

[Daniele Castagna, 2016-09-23 22:16:24]

dcastagna@chromium.org changed reviewers:
+ sievers@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:16:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniele Castagna, 2016-09-23 22:17:18]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:17:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 23:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 23:41:17]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Daniele Castagna, 2016-09-24 01:21:08]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-09-24 01:21:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 02:06:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-24 02:08:33]

Description was changed from

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
TBR=sievers
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Cr-Commit-Position: refs/heads/master@{#418096}
==========

to

==========
Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG=646148, b/31159410,b/29625228
TBR=sievers
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Committed: https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e
Cr-Original-Commit-Position: refs/heads/master@{#418096}
Cr-Commit-Position: refs/heads/master@{#420815}
==========

[commit-bot: I haz the power, 2016-09-24 02:08:34]

Patchset 4 (id:??) landed as
https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e
Cr-Commit-Position: refs/heads/master@{#420815}