Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2296393005: Revert of Quic: add unittests for reduced PING Timeout (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Quic: add unittests for reduced PING Timeout (patchset #2 id:20001 of https://codereview.chromium.org/2307933003/ ) Reason for revert: Broke cronet compile: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder/builds/1164 ../../net/quic/core/quic_connection_test.cc:2980:8: error: redefinition of 'class net::test::{anonymous}::QuicConnectionTest_ReducedPingTimeout_Test' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ ../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note: in definition of macro 'GTEST_TEST_CLASS_NAME_' test_case_name##_##test_name##_Test ^ ../../net/quic/core/quic_connection_test.cc:2980:1: note: in expansion of macro 'TEST_P' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ ../../net/quic/core/quic_connection_test.cc:2935:8: error: previous definition of 'class net::test::{anonymous}::QuicConnectionTest_ReducedPingTimeout_Test' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ ../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note: in definition of macro 'GTEST_TEST_CLASS_NAME_' test_case_name##_##test_name##_Test ^ ../../net/quic/core/quic_connection_test.cc:2935:1: note: in expansion of macro 'TEST_P' TEST_P(QuicConnectionTest, ReducedPingTimeout) { ^ Original issue's description: > Quic: add unittests for reduced PING Timeout > > BUG= > > Committed: https://crrev.com/df9cb098cf816fb589e0ad6627012b524c78e9eb > Cr-Commit-Position: refs/heads/master@{#416401} TBR=rch@chromium.org,zhongyi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1e332ed52c01507a37c3c47c66496bdc986ff703 Cr-Commit-Position: refs/heads/master@{#416407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -51 lines) Patch
M net/quic/core/quic_connection.h View 1 chunk +4 lines, -6 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
agrieve
Created Revert of Quic: add unittests for reduced PING Timeout
4 years, 3 months ago (2016-09-03 00:25:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296393005/1
4 years, 3 months ago (2016-09-03 00:26:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-03 00:27:33 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:30:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e332ed52c01507a37c3c47c66496bdc986ff703
Cr-Commit-Position: refs/heads/master@{#416407}

Powered by Google App Engine
This is Rietveld 408576698