Revert of Add groupid for media devices. Group audio devices.

Revert of Add groupid for media devices. Group audio devices. (patchset #5 id:80001 of https://codereview.chromium.org/2273653002/ )

Reason for revert:
Breaks webrtc FYI bots on mac https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143. I'll have to figure out what's up with that ¯\_(ツ)_/¯

Original issue's description:
> Add groupid for media devices. Group audio devices.
>
> At present, the renderer tries to use matched_output_device
> to assign groupids to audio devices. matched_output_device isn't set
> before devices are sent to the renderer, and we wouldn't be able to
> handle all the cases with it anyways.
>
> BUG=636300, 627793
>
> Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> Cr-Commit-Position: refs/heads/master@{#416140}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636300, 627793
Committed: https://crrev.com/0c747762e50c0452f7809fa48249a1a776ff43d2
Cr-Commit-Position: refs/heads/master@{#416217}

[Max Morin, 2016-09-02 09:00:36]

The CQ bit was checked by maxmorin@chromium.org

[Max Morin, 2016-09-02 09:00:36]

Created Revert of Add groupid for media devices. Group audio devices.

[commit-bot: I haz the power, 2016-09-02 09:00:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 09:00:56]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tommi (sloooow) - chröme, 2016-09-02 09:03:08]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2016-09-02 09:03:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 09:03:32]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tommi (sloooow) - chröme, 2016-09-02 09:08:59]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2016-09-02 09:09:00]

lgtm

[commit-bot: I haz the power, 2016-09-02 09:09:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:10:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 09:13:35]

Description was changed from

==========
Revert of Add groupid for media devices. Group audio devices. (patchset #5
id:80001 of https://codereview.chromium.org/2273653002/ )

Reason for revert:
Breaks webrtc FYI bots on mac
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143.
I'll have to figure out what's up with that ¯\_(ツ)_/¯

Original issue's description:
> Add groupid for media devices. Group audio devices.
> 
> At present, the renderer tries to use matched_output_device
> to assign groupids to audio devices. matched_output_device isn't set
> before devices are sent to the renderer, and we wouldn't be able to
> handle all the cases with it anyways.
> 
> BUG=636300, 627793
> 
> Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> Cr-Commit-Position: refs/heads/master@{#416140}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636300, 627793
==========

to

==========
Revert of Add groupid for media devices. Group audio devices. (patchset #5
id:80001 of https://codereview.chromium.org/2273653002/ )

Reason for revert:
Breaks webrtc FYI bots on mac
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143.
I'll have to figure out what's up with that ¯\_(ツ)_/¯

Original issue's description:
> Add groupid for media devices. Group audio devices.
>
> At present, the renderer tries to use matched_output_device
> to assign groupids to audio devices. matched_output_device isn't set
> before devices are sent to the renderer, and we wouldn't be able to
> handle all the cases with it anyways.
>
> BUG=636300, 627793
>
> Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> Cr-Commit-Position: refs/heads/master@{#416140}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636300, 627793

Committed: https://crrev.com/0c747762e50c0452f7809fa48249a1a776ff43d2
Cr-Commit-Position: refs/heads/master@{#416217}
==========

[commit-bot: I haz the power, 2016-09-02 09:13:37]

Patchset 1 (id:??) landed as
https://crrev.com/0c747762e50c0452f7809fa48249a1a776ff43d2
Cr-Commit-Position: refs/heads/master@{#416217}

[Guido Urdaneta, 2016-09-02 09:16:36]

https://codereview.chromium.org/2296393004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/media_stream_manager.cc (left):

https://codereview.chromium.org/2296393004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/media_stream_manager.cc:770:
device_info.device.group_id =
The problem with the failed test is that you are calling GetGroupIDOutput on the
IO thread here.

You should do it on audio_manager_->GetTaskRunner(), as in
https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/medi...

Sorry for not catching that during the regular review :)

[Max Morin, 2016-09-05 10:55:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2313663002/ by maxmorin@chromium.org.

The reason for reverting is: I'm fixing the threading issue now..