views_examples: add Button sticker sheet

views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790
Committed: https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8
Cr-Commit-Position: refs/heads/master@{#416280}

[Elly Fong-Jones, 2016-09-01 14:46:14]

Description was changed from

==========
views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790
==========

to

==========
views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790
==========

[Elly Fong-Jones, 2016-09-01 14:46:14]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-09-01 14:46:21]

sky: ptal? :)

[sky, 2016-09-01 19:28:40]

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
File ui/views/examples/button_sticker_sheet.cc (right):

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
ui/views/examples/button_sticker_sheet.cc:94: layout, "",
{MakePlainLabel("Primary"), MakePlainLabel("Secondary")});
"" -> std::string()

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
File ui/views/examples/button_sticker_sheet.h (right):

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
ui/views/examples/button_sticker_sheet.h:16: // design button styles. This
example only looks right with `--secondary-ui-md`.
I think you should show some warning text at the bottom if secondary-ui-md isn't
specific.

[Elly Fong-Jones, 2016-09-02 11:29:39]

sky: ptal? :)

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
File ui/views/examples/button_sticker_sheet.cc (right):

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
ui/views/examples/button_sticker_sheet.cc:94: layout, "",
{MakePlainLabel("Primary"), MakePlainLabel("Secondary")});
On 2016/09/01 19:28:40, sky wrote:
> "" -> std::string()

Done.

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
File ui/views/examples/button_sticker_sheet.h (right):

https://codereview.chromium.org/2296343004/diff/1/ui/views/examples/button_st...
ui/views/examples/button_sticker_sheet.h:16: // design button styles. This
example only looks right with `--secondary-ui-md`.
On 2016/09/01 19:28:40, sky wrote:
> I think you should show some warning text at the bottom if secondary-ui-md
isn't
> specific.

Done.

[sky, 2016-09-02 14:31:19]

LGTM

https://codereview.chromium.org/2296343004/diff/20001/ui/views/examples/butto...
File ui/views/examples/button_sticker_sheet.cc (right):

https://codereview.chromium.org/2296343004/diff/20001/ui/views/examples/butto...
ui/views/examples/button_sticker_sheet.cc:45: View* MakePlainLabel(const
std::string& text) {
optional: I wouldn't bother with a one line function for this. It isn't really
buying you much.

[Elly Fong-Jones, 2016-09-02 14:51:10]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-02 14:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 16:20:49]

Description was changed from

==========
views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790
==========

to

==========
views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790
==========

[commit-bot: I haz the power, 2016-09-02 16:20:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 16:22:00]

Description was changed from

==========
views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790
==========

to

==========
views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790

Committed: https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8
Cr-Commit-Position: refs/heads/master@{#416280}
==========

[commit-bot: I haz the power, 2016-09-02 16:22:01]

Patchset 2 (id:??) landed as
https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8
Cr-Commit-Position: refs/heads/master@{#416280}