Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2296333002: Inline chrome/browser/ui GYP files into GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline chrome/browser/ui GYP files into GN build. Remove chrome_browser_ui.gypi TBR=dpranke Committed: https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499 Cr-Commit-Position: refs/heads/master@{#415793}

Patch Set 1 #

Patch Set 2 : Themes #

Patch Set 3 : Fix Android #

Patch Set 4 : Theme source again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2776 lines, -3496 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 3 21 chunks +2776 lines, -152 lines 0 comments Download
D chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -3344 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
brettw
4 years, 3 months ago (2016-08-31 21:12:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296333002/1
4 years, 3 months ago (2016-08-31 21:13:05 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/121795) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-08-31 21:18:12 UTC) #5
brettw
Themes
4 years, 3 months ago (2016-08-31 21:22:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296333002/20001
4 years, 3 months ago (2016-08-31 21:22:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/121999) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-08-31 21:33:22 UTC) #10
brettw
Fix Android
4 years, 3 months ago (2016-08-31 21:34:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296333002/40001
4 years, 3 months ago (2016-08-31 21:35:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/192924) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-08-31 21:45:41 UTC) #15
brettw
Theme source again
4 years, 3 months ago (2016-08-31 22:00:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296333002/60001
4 years, 3 months ago (2016-08-31 22:02:03 UTC) #18
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-31 22:03:13 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-31 23:07:54 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:10:26 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499
Cr-Commit-Position: refs/heads/master@{#415793}

Powered by Google App Engine
This is Rietveld 408576698