third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h - Issue 2296323002: DevTools: Add features to collect classnames from Stylesheets and DOM

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

Issue 2296323002: DevTools: Add features to collect classnames from Stylesheets and DOM (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names.html ('K') | « third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names-expected.txt ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

index 8d5898de322302a3f6eb73854494a8cdb687a37b..7ede55eb5af0624b2aac2d46c2de332efa8e61cb 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

@@ -105,6 +105,7 @@ public:

static void collectAllDocumentStyleSheets(Document*, HeapVector<Member<CSSStyleSheet>>&);

lushnikov 2016/09/01 20:50:35 nit: stray line

ahmetemirercin 2016/09/02 19:59:54 Done.

~InspectorCSSAgent() override;

DECLARE_VIRTUAL_TRACE();

@@ -125,6 +126,7 @@ public:

void getInlineStylesForNode(ErrorString*, int nodeId, Maybe<protocol::CSS::CSSStyle>* inlineStyle, Maybe<protocol::CSS::CSSStyle>* attributesStyle) override;

void getComputedStyleForNode(ErrorString*, int nodeId, std::unique_ptr<protocol::Array<protocol::CSS::CSSComputedStyleProperty>>*) override;

void getPlatformFontsForNode(ErrorString*, int nodeId, std::unique_ptr<protocol::Array<protocol::CSS::PlatformFontUsage>>* fonts) override;

+ void collectClassNamesFromStyleSheet(ErrorString*, const String& styleSheetId, Maybe<protocol::Array<String>>* classNames) override;

void getStyleSheetText(ErrorString*, const String& styleSheetId, String* text) override;

void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text, Maybe<String>* sourceMapURL) override;

void setRuleSelector(ErrorString*, const String& styleSheetId, std::unique_ptr<protocol::CSS::SourceRange>, const String& selector, std::unique_ptr<protocol::CSS::SelectorList>*) override;

@@ -137,7 +139,6 @@ public:

void getMediaQueries(ErrorString*, std::unique_ptr<protocol::Array<protocol::CSS::CSSMedia>>*) override;

void setEffectivePropertyValueForNode(ErrorString*, int nodeId, const String& propertyName, const String& value) override;

void getBackgroundColors(ErrorString*, int nodeId, Maybe<protocol::Array<String>>* backgroundColors) override;

lushnikov 2016/09/01 20:50:35 let's keep this - it separated media query builder

ahmetemirercin 2016/09/02 19:59:54 Done.

void collectMediaQueriesFromRule(CSSRule*, protocol::Array<protocol::CSS::CSSMedia>*);

void collectMediaQueriesFromStyleSheet(CSSStyleSheet*, protocol::Array<protocol::CSS::CSSMedia>*);

std::unique_ptr<protocol::CSS::CSSMedia> buildMediaObject(const MediaList*, MediaListSource, const String&, CSSStyleSheet*);