third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names.html - Issue 2296323002: DevTools: Add features to collect classnames from Stylesheets and DOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names.html

Issue 2296323002: DevTools: Add features to collect classnames from Stylesheets and DOM (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/css/css-collect-class-names.html ('K') | « third_party/WebKit/LayoutTests/inspector-protocol/css/resources/collect-class-names-imported.css ('k') | third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names-expected.txt » ('j') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>

	4 <script>

	5

	6 function test()

	7 {

	8 InspectorTest.sendCommand("DOM.getDocument", {}, onGotDocument);

	9 InspectorTest.sendCommand("DOM.enable", {});

	10 function onGotDocument(msg)

	11 {

	12 rootNodeId = msg.result.root.nodeId;

	13 InspectorTest.sendCommandOrDie("DOM.collectClassNames", { nodeId: rootNo deId }, onClassNamesCollected);

	14 }

	15 function onClassNamesCollected(response)
	lushnikov 2016/09/01 20:50:35 nit: let's have a line between functions nit: let's have a line between functions ahmetemirercin 2016/09/02 19:59:54 Done. Show quoted text On 2016/09/01 20:50:35, lushnikov wrote: > nit: let's have a line between functions Done.
	16 {

	17
	lushnikov 2016/09/01 20:50:35 nit: stray line nit: stray line ahmetemirercin 2016/09/02 19:59:54 Done. Show quoted text On 2016/09/01 20:50:35, lushnikov wrote: > nit: stray line Done.
	18 var classNames = response.classNames;

	19 classNames.sort(function (a, b)
	lushnikov 2016/09/01 20:50:35 doesn't the default comparator work good enough? doesn't the default comparator work good enough? ahmetemirercin 2016/09/02 19:59:54 Done. Show quoted text On 2016/09/01 20:50:35, lushnikov wrote: > doesn't the default comparator work good enough? Done.
	20 {

	21 if (a < b)

	22 return -1

	23 if (a > b)

	24 return 1;

	25 return 0;

	26 });

	27 for(var i=0; i < classNames.length; i++)

	28 InspectorTest.log(classNames[i]);

	29

	30 InspectorTest.completeTest();

	31 }

	32 }

	33

	34 </script>

	35 </head>

	36 <body onload="runTest()" class='body_class'>

	37 <div class='class1'></div>

	38 <div class='class2'>

	39 <ul class='class3'>
	lushnikov 2016/09/01 20:50:35 let's make sure it collects from shadow DOM as wel let's make sure it collects from shadow DOM as well ahmetemirercin 2016/09/02 19:59:54 Done. Show quoted text On 2016/09/01 20:50:35, lushnikov wrote: > let's make sure it collects from shadow DOM as well Done.
	40 <li class='class4'></li>

	41 </ul>

	42 </div>

	43 <div class='class5 class6'></div>

	44 </body>

	45 </html>

OLD	NEW