Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: components/test_runner/event_sender.cc

Issue 2296303002: Make a pen in eraser mode visible thru PointerEvent.buttons (Closed)
Patch Set: Incremental patch on crrev.com/2289273002 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/event_sender.cc
diff --git a/components/test_runner/event_sender.cc b/components/test_runner/event_sender.cc
index e11fc9eea97782ec6ac3890b69a64330d8dff9ec..9e6535948ff9b83606070ac613c1bca7092f520d 100644
--- a/components/test_runner/event_sender.cc
+++ b/components/test_runner/event_sender.cc
@@ -63,10 +63,11 @@ namespace test_runner {
namespace {
const int kRawMousePointerId = -1;
-const char* kPointerTypeStringUnknown = "";
-const char* kPointerTypeStringMouse = "mouse";
-const char* kPointerTypeStringPen = "pen";
-const char* kPointerTypeStringTouch = "touch";
+const char* const kPointerTypeStringUnknown = "";
+const char* const kPointerTypeStringMouse = "mouse";
+const char* const kPointerTypeStringTouch = "touch";
+const char* const kPointerTypeStringPen = "pen";
+const char* const kPointerTypeStringEraser = "eraser";
// Assigns |pointerType| from the provided |args|. Returns false if there was
// any error.
@@ -90,10 +91,12 @@ bool getPointerType(gin::Arguments* args,
pointerType = WebMouseEvent::PointerType::Unknown;
} else if (pointer_type_string == kPointerTypeStringMouse) {
pointerType = WebMouseEvent::PointerType::Mouse;
- } else if (pointer_type_string == kPointerTypeStringPen) {
- pointerType = WebMouseEvent::PointerType::Pen;
} else if (pointer_type_string == kPointerTypeStringTouch) {
pointerType = WebMouseEvent::PointerType::Touch;
+ } else if (pointer_type_string == kPointerTypeStringPen) {
+ pointerType = WebMouseEvent::PointerType::Pen;
+ } else if (pointer_type_string == kPointerTypeStringEraser) {
+ pointerType = WebMouseEvent::PointerType::Eraser;
} else {
args->ThrowError();
return false;

Powered by Google App Engine
This is Rietveld 408576698