Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 22963004: Measure usage for Element methods removed from DOM4 (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos
Visibility:
Public.

Description

Measure usage for Element methods removed from DOM4 Measure usage for the following Element methods removed from DOM4: - getAttributeNode() - getAttributeNodeNS() - setAttributeNode() - removeAttributeNode() This will help us determine if we should deprecate them or if they should be reintroduced in DOM4. R=arv BUG=272098 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156024

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M Source/core/dom/Element.idl View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-13 12:50:40 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-13 13:22:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22963004/6001
7 years, 4 months ago (2013-08-13 14:37:52 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 15:36:31 UTC) #4
Message was sent while issue was closed.
Change committed as 156024

Powered by Google App Engine
This is Rietveld 408576698