webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc - Issue 2296253002: Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

Issue 2296253002: Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true (Closed)

Patch Set: Added plot function which considers ssrc Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/overuse_detector.cc ('K') | « webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc » ('j') | webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

index bcd360d88ab34c7ac8fd939069e61c70e8c6e321..62d8c282ee24ce789c074b171cc74fcdc42c56db 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

@@ -314,7 +314,8 @@ void RemoteBitrateEstimatorAbsSendTime::IncomingPacketInfo(

payload_size, &ts_delta, &t_delta,

&size_delta)) {

double ts_delta_ms = (1000.0 * ts_delta) / (1 << kInterArrivalShift);

- estimator_->Update(t_delta, ts_delta_ms, size_delta, detector_.State());

+ estimator_->Update(t_delta, ts_delta_ms, size_delta, detector_.State(),

+ arrival_time_ms);

stefan-webrtc 2016/09/02 11:13:04 This is not correctly indented. Run 'git cl format

detector_.Detect(estimator_->offset(), ts_delta_ms,

estimator_->num_of_deltas(), arrival_time_ms);

}