Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h"
 
 #include <math.h>
 
 #include <cstdlib>
 
 #include "webrtc/modules/rtp_rtcp/source/rtp_rtcp_config.h"
 #include "webrtc/modules/rtp_rtcp/source/time_util.h"
 
+#include "webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"

[stefan-webrtc, 2016/09/01 14:07:36]

Order alphabetically (should go before rtp_rtcp)

[Gaetano Carlucci, 2016/09/01 16:06:26]

ok

+
 namespace webrtc {
 
 const int64_t kStatisticsTimeoutMs = 8000;
 const int64_t kStatisticsProcessIntervalMs = 1000;
 
 StreamStatistician::~StreamStatistician() {}
 
 StreamStatisticianImpl::StreamStatisticianImpl(
     Clock* clock,
     RtcpStatisticsCallback* rtcp_callback,
@@ skipping 239 matching lines @@
 
   // Store this report.
   last_reported_statistics_ = stats;
 
   // Only for report blocks in RTCP SR and RR.
   last_report_inorder_packets_ =
       receive_counters_.transmitted.packets -
       receive_counters_.retransmitted.packets;
   last_report_old_packets_ = receive_counters_.retransmitted.packets;
   last_report_seq_max_ = received_seq_max_;
+  char str[80];
+  snprintf(str, sizeof(str), "%d cumulative_loss[pkts]", ssrc_);
+  BWE_TEST_LOGGING_PLOT(1, str, clock_->TimeInMilliseconds(), cumulative_loss_);

[stefan-webrtc, 2016/09/01 14:07:36]

Instead of doing snprintf here I'd suggest you make a new version of
BWE_TEST_LOGGING_PLOT which also takes an ssrc. That way we don't have to do
snprintf in the case where test logging is disabled.

Also consider using stringstream instead of snprintf as you wouldn't have to
allocate 80 bytes which is more than needed.

[Gaetano Carlucci, 2016/09/01 16:06:26]

ok

+  snprintf(str, sizeof(str), "%d received_seq_max[pkts]", ssrc_);
+  BWE_TEST_LOGGING_PLOT(1, str, clock_->TimeInMilliseconds(), \
+    (received_seq_max_ - received_seq_first_));
 
   return stats;
 }
 
 void StreamStatisticianImpl::GetDataCounters(
     size_t* bytes_received, uint32_t* packets_received) const {
   rtc::CritScope cs(&stream_lock_);
   if (bytes_received) {
     *bytes_received = receive_counters_.transmitted.payload_bytes +
                       receive_counters_.transmitted.header_bytes +
@@ skipping 214 matching lines @@
 void NullReceiveStatistics::SetMaxReorderingThreshold(
     int max_reordering_threshold) {}
 
 void NullReceiveStatistics::RegisterRtcpStatisticsCallback(
     RtcpStatisticsCallback* callback) {}
 
 void NullReceiveStatistics::RegisterRtpStatisticsCallback(
     StreamDataCountersCallback* callback) {}
 
 }  // namespace webrtc