Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 229623002: Plumb request_context, ipc_process_id, and blob_storage_context through to where they'll be needed. (Closed)

Created:
6 years, 8 months ago by ericu
Modified:
6 years, 8 months ago
Reviewers:
jsbell, cmumford, sky
CC:
chromium-reviews, creis+watch_chromium.org, jam, nasko+codewatch_chromium.org, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Plumb request_context, ipc_process_id, and blob_storage_context through to where they'll be needed. BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263693

Patch Set 1 #

Patch Set 2 : Found some nits #

Total comments: 6

Patch Set 3 : Nit fixes #

Total comments: 2

Patch Set 4 : Fix a test mock which was missing a param. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -23 lines) Patch
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 2 5 chunks +22 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 6 chunks +42 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.h View 4 chunks +8 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory.cc View 1 2 7 chunks +7 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 2 3 9 chunks +37 lines, -11 lines 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
ericu
6 years, 8 months ago (2014-04-08 23:04:56 UTC) #1
cmumford
https://codereview.chromium.org/229623002/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.h File content/browser/indexed_db/indexed_db_dispatcher_host.h (right): https://codereview.chromium.org/229623002/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.h#newcode72 content/browser/indexed_db/indexed_db_dispatcher_host.h:72: webkit_blob::BlobStorageContext* blob_storage_context() { Can this method be const? https://codereview.chromium.org/229623002/diff/20001/content/browser/indexed_db/indexed_db_factory.cc ...
6 years, 8 months ago (2014-04-08 23:29:29 UTC) #2
ericu
https://codereview.chromium.org/229623002/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.h File content/browser/indexed_db/indexed_db_dispatcher_host.h (right): https://codereview.chromium.org/229623002/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.h#newcode72 content/browser/indexed_db/indexed_db_dispatcher_host.h:72: webkit_blob::BlobStorageContext* blob_storage_context() { On 2014/04/08 23:29:29, cmumford wrote: > ...
6 years, 8 months ago (2014-04-09 18:02:45 UTC) #3
cmumford
lgtm
6 years, 8 months ago (2014-04-09 18:03:44 UTC) #4
jsbell
https://codereview.chromium.org/229623002/diff/40001/content/browser/indexed_db/indexed_db_dispatcher_host.h File content/browser/indexed_db/indexed_db_dispatcher_host.h (right): https://codereview.chromium.org/229623002/diff/40001/content/browser/indexed_db/indexed_db_dispatcher_host.h#newcode47 content/browser/indexed_db/indexed_db_dispatcher_host.h:47: IndexedDBDispatcherHost(int ipc_process_id, I'm being dumb - can you point ...
6 years, 8 months ago (2014-04-09 20:31:14 UTC) #5
ericu
https://codereview.chromium.org/229623002/diff/40001/content/browser/indexed_db/indexed_db_dispatcher_host.h File content/browser/indexed_db/indexed_db_dispatcher_host.h (right): https://codereview.chromium.org/229623002/diff/40001/content/browser/indexed_db/indexed_db_dispatcher_host.h#newcode47 content/browser/indexed_db/indexed_db_dispatcher_host.h:47: IndexedDBDispatcherHost(int ipc_process_id, On 2014/04/09 20:31:14, jsbell wrote: > I'm ...
6 years, 8 months ago (2014-04-09 20:48:45 UTC) #6
jsbell
On 2014/04/09 20:48:45, ericu wrote: > https://codereview.chromium.org/229623002/diff/40001/content/browser/indexed_db/indexed_db_dispatcher_host.h > File content/browser/indexed_db/indexed_db_dispatcher_host.h (right): > > https://codereview.chromium.org/229623002/diff/40001/content/browser/indexed_db/indexed_db_dispatcher_host.h#newcode47 > ...
6 years, 8 months ago (2014-04-09 20:52:58 UTC) #7
ericu
+sky for owners approval for render_process_host_impl.cc and worker_process_host.cc.
6 years, 8 months ago (2014-04-09 21:00:43 UTC) #8
sky
LGTM
6 years, 8 months ago (2014-04-10 14:50:47 UTC) #9
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 8 months ago (2014-04-10 15:07:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/229623002/40001
6 years, 8 months ago (2014-04-10 15:07:16 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 16:12:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-10 16:12:20 UTC) #13
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 8 months ago (2014-04-14 17:11:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/229623002/60001
6 years, 8 months ago (2014-04-14 17:12:51 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 19:04:38 UTC) #16
Message was sent while issue was closed.
Change committed as 263693

Powered by Google App Engine
This is Rietveld 408576698