content/browser/tracing/trace_subscriber_stdio.cc - Issue 22962004: Thread-local trace-event buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/trace_subscriber_stdio.cc

Issue 22962004: Thread-local trace-event buffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/trace_subscriber_stdio.cc

diff --git a/content/browser/tracing/trace_subscriber_stdio.cc b/content/browser/tracing/trace_subscriber_stdio.cc

index 35b96464e74b80ed0933f035c19b8e1ac46ca52f..2c6aede56cef0738459828dda7b8d58b04daa925 100644

--- a/content/browser/tracing/trace_subscriber_stdio.cc

+++ b/content/browser/tracing/trace_subscriber_stdio.cc

@@ -46,6 +46,7 @@ class TraceSubscriberStdio::TraceSubscriberStdioWorker

void OnTraceData(const scoped_refptr<base::RefCountedString>& data_ptr) {

if (!IsValid())

return;

+ DCHECK(!data_ptr->data().empty());

if (needs_comma_)

WriteString(",");

WriteString(data_ptr->data());