Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 22962003: Remove support for [IsIndex] IDL extended attribute (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use, lgombos
Visibility:
Public.

Description

Remove support for [IsIndex] IDL extended attribute Remove support for [IsIndex] IDL extended attribute as it is no longer needed and it increases the complexity of the bindings generator. BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -47 lines) Patch
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 6 chunks +0 lines, -38 lines 0 comments Download
M Source/bindings/tests/idls/TestEventTarget.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-13 18:08:32 UTC) #1
arv (Not doing code reviews)
LGTM++
7 years, 4 months ago (2013-08-13 18:19:09 UTC) #2
haraken
LGTM. Awesome.
7 years, 4 months ago (2013-08-14 00:50:50 UTC) #3
Nils Barth (inactive)
LGTM! Thanks, this is great!
7 years, 4 months ago (2013-08-14 00:55:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22962003/1
7 years, 4 months ago (2013-08-14 06:16:37 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 07:50:24 UTC) #6
Message was sent while issue was closed.
Change committed as 156080

Powered by Google App Engine
This is Rietveld 408576698