Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2296193004: [Extensions] Update sockets owners (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update sockets owners Add steel@ and xiyuan@ as sockets owners. BUG=None Committed: https://crrev.com/eb05902d04d62b17026fe61949d545d90df61a5b Cr-Commit-Position: refs/heads/master@{#415737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M extensions/browser/api/sockets_tcp/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp_server/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_udp/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Devlin
PTAL. I haven't added michaelpg@ or tbarzic@ yet, but feel free to if you like.
4 years, 3 months ago (2016-08-31 17:07:46 UTC) #2
xiyuan
lgtm
4 years, 3 months ago (2016-08-31 17:09:46 UTC) #5
Rahul Chaturvedi
lgtm
4 years, 3 months ago (2016-08-31 20:07:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296193004/1
4 years, 3 months ago (2016-08-31 20:14:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:18:47 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:20:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb05902d04d62b17026fe61949d545d90df61a5b
Cr-Commit-Position: refs/heads/master@{#415737}

Powered by Google App Engine
This is Rietveld 408576698