Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2296193002:
Use CheckedNumeric for strength calculation. (Closed)
DescriptionUse CheckedNumeric for strength calculation.
Update the calculation of the outlines bold strength to use a CheckedNum instead of an int.
BUG=chromium:639506
Committed: https://pdfium.googlesource.com/pdfium/+/07146149674c61eaecf55cdfe6cdf7c31bbf0550
Patch Set 1 #
Total comments: 4
Patch Set 2 : review feedback #Patch Set 3 : Fix operation order #Messages
Total messages: 23 (16 generated)
The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dsinclair@chromium.org changed reviewers: + thestig@chromium.org, weili@chromium.org
PTAL.
https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.cpp File core/fxge/ge/cfx_facecache.cpp (right): https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.... core/fxge/ge/cfx_facecache.cpp:157: FT_Pos level = 0; This may not work on some platform such as Windows, where 'signed long' is still 4 bytes.
https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.cpp File core/fxge/ge/cfx_facecache.cpp (right): https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.... core/fxge/ge/cfx_facecache.cpp:165: static_cast<FT_Pos>(FXSYS_abs(static_cast<int>(ft_matrix.xx)) + BTW, can we combine the similar portions of the if/else blocks?
The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.cpp File core/fxge/ge/cfx_facecache.cpp (right): https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.... core/fxge/ge/cfx_facecache.cpp:157: FT_Pos level = 0; On 2016/08/31 16:59:37, Wei Li wrote: > This may not work on some platform such as Windows, where 'signed long' is still > 4 bytes. Switched to CheckedNumeric. https://codereview.chromium.org/2296193002/diff/1/core/fxge/ge/cfx_facecache.... core/fxge/ge/cfx_facecache.cpp:165: static_cast<FT_Pos>(FXSYS_abs(static_cast<int>(ft_matrix.xx)) + On 2016/08/31 17:34:27, Lei Zhang wrote: > BTW, can we combine the similar portions of the if/else blocks? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_xfa on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Description was changed from ========== Use FT_Pos for strength calculation. Update the calculation of the outlines bold strength to use an FT_Pos (signed long) instead of an int. BUG=chromium:639506 ========== to ========== Use CheckedNumeric for strength calculation. Update the calculation of the outlines bold strength to use a CheckedNum instead of an int. BUG=chromium:639506 ==========
The CQ bit was checked by dsinclair@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use CheckedNumeric for strength calculation. Update the calculation of the outlines bold strength to use a CheckedNum instead of an int. BUG=chromium:639506 ========== to ========== Use CheckedNumeric for strength calculation. Update the calculation of the outlines bold strength to use a CheckedNum instead of an int. BUG=chromium:639506 Committed: https://pdfium.googlesource.com/pdfium/+/07146149674c61eaecf55cdfe6cdf7c31bbf... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://pdfium.googlesource.com/pdfium/+/07146149674c61eaecf55cdfe6cdf7c31bbf... |
