Remove some more LabelButton::STYLE_BUTTON references.

Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
TBR=mkwst@chromium.org

Committed: https://crrev.com/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87
Cr-Commit-Position: refs/heads/master@{#416041}

[Evan Stade, 2016-09-01 00:55:34]

estade@chromium.org changed reviewers:
+ jamescook@chromium.org

[Evan Stade, 2016-09-01 00:55:35]

https://codereview.chromium.org/2296173004/diff/1/content/shell/browser/shell...
File content/shell/browser/shell_views.cc (right):

https://codereview.chromium.org/2296173004/diff/1/content/shell/browser/shell...
content/shell/browser/shell_views.cc:135:
views::MdTextButton::CreateMdButton(this, base::ASCIIToUTF16("Back"));
I'm not sure how many times you need to use a views class before it becomes
worthwhile to 'using' it. I will do so here if you prefer.

[James Cook, 2016-09-01 02:35:58]

LGTM

https://codereview.chromium.org/2296173004/diff/1/ash/shell/widgets.cc
File ash/shell/widgets.cc (right):

https://codereview.chromium.org/2296173004/diff/1/ash/shell/widgets.cc#newcode60
ash/shell/widgets.cc:60: NULL,
nit: nullptr since you're touching the lines anyway

https://codereview.chromium.org/2296173004/diff/1/content/shell/browser/shell...
File content/shell/browser/shell_views.cc (right):

https://codereview.chromium.org/2296173004/diff/1/content/shell/browser/shell...
content/shell/browser/shell_views.cc:135:
views::MdTextButton::CreateMdButton(this, base::ASCIIToUTF16("Back"));
On 2016/09/01 00:55:35, Evan Stade wrote:
> I'm not sure how many times you need to use a views class before it becomes
> worthwhile to 'using' it. I will do so here if you prefer.

This seems fine. The wrapping here isn't too bad.

[Evan Stade, 2016-09-01 20:02:20]

estade@chromium.org changed reviewers:
+ mkwst@chromium.org

[Evan Stade, 2016-09-01 20:02:20]

+TBR mkwst for mechanical changes in content/shell/browser/shell_views.cc

[Evan Stade, 2016-09-01 20:02:30]

Description was changed from

==========
Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
==========

to

==========
Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
TBR=mkwst@chromium.org
==========

[Evan Stade, 2016-09-01 20:02:33]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-01 20:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2296173004/#ps20001
(title: "nullptr")

[Evan Stade, 2016-09-01 20:02:45]

https://codereview.chromium.org/2296173004/diff/1/ash/shell/widgets.cc
File ash/shell/widgets.cc (right):

https://codereview.chromium.org/2296173004/diff/1/ash/shell/widgets.cc#newcode60
ash/shell/widgets.cc:60: NULL,
On 2016/09/01 02:35:57, James Cook wrote:
> nit: nullptr since you're touching the lines anyway

Done.

[commit-bot: I haz the power, 2016-09-01 20:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:46:11]

Description was changed from

==========
Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
TBR=mkwst@chromium.org
==========

to

==========
Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
TBR=mkwst@chromium.org
==========

[commit-bot: I haz the power, 2016-09-01 20:46:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 20:49:40]

Description was changed from

==========
Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
TBR=mkwst@chromium.org
==========

to

==========
Remove some more LabelButton::STYLE_BUTTON references.

BUG=642920
TBR=mkwst@chromium.org

Committed: https://crrev.com/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87
Cr-Commit-Position: refs/heads/master@{#416041}
==========

[commit-bot: I haz the power, 2016-09-01 20:49:41]

Patchset 2 (id:??) landed as
https://crrev.com/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87
Cr-Commit-Position: refs/heads/master@{#416041}