Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2296173002:
[M53] Disable CMAA for samus (Closed)
|
Created:
4 years, 3 months ago by robert.bradford Modified:
4 years, 3 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/branch-heads/2785 Project:
chromium Visibility:
Public. |
Description[M53] Disable CMAA for samus
Selective enabling for CMAA on samus was added in https://crrev.com/402913 by
using a workaround with an exception to turn it on.
It was found that this caused a graphics corruption issue with the Camera app.
This CL is the minimal change to disable the feature by removing the samus PCI
ID from the list of exceptions to the workaround which disables CMAA.
BUG=642290
TEST=Bisecter reported reverting this commit resolved corruption issues.
NOPRESUBMIT=true
NOTRY=true
Patch Set 1 #Patch Set 2 : Just remove exceptions block #Messages
Total messages: 20 (9 generated)
Description was changed from ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing it entirely from the workaround file. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. ========== to ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing it entirely from the workaround file. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
piman@chromium.org changed reviewers: + piman@chromium.org, zmo@chromium.org
I don't think this CL disables CMAA, it removes the entry that disables it everywhere except samus. Maybe you meant to remove the 'exceptions' block?
Description was changed from ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing it entirely from the workaround file. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2016/08/31 19:44:48, piman wrote: > I don't think this CL disables CMAA, it removes the entry that disables it > everywhere except samus. > > Maybe you meant to remove the 'exceptions' block? Fixed. Thank you. :-) I'm in the process of building a R53 image so that I can verify that this resolves the problem.
Description was changed from ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2016/09/01 13:09:12, robert.bradford wrote: > On 2016/08/31 19:44:48, piman wrote: > > I don't think this CL disables CMAA, it removes the entry that disables it > > everywhere except samus. > > > > Maybe you meant to remove the 'exceptions' block? > > Fixed. Thank you. :-) I'm in the process of building a R53 image so that I can > verify that this resolves the problem. That means you lost multisampling on the device. I don't know much about the device, so I am not objecting this CL, just saying.
lgtm if that's what you feel best way forward
lgtm
The CQ bit was checked by piman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
On 2016/09/02 03:40:02, piman wrote: > The CQ bit was checked by mailto:piman@chromium.org This change is against the R53 branch. I have to git cl land it rather than the CQ, right?
Description was changed from ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. NOPRESUBMIT=true NOTRY=true ==========
On 2016/09/02 08:38:29, robert.bradford wrote: > On 2016/09/02 03:40:02, piman wrote: > > The CQ bit was checked by mailto:piman@chromium.org > > This change is against the R53 branch. I have to git cl land it rather than the > CQ, right? Torne informs me I can use CQ if NOPRESUBMIT=true and NOTRY=true. So doing that.
The CQ bit was checked by robert.bradford@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. NOPRESUBMIT=true NOTRY=true ========== to ========== [M53] Disable CMAA for samus Selective enabling for CMAA on samus was added in https://crrev.com/402913 by using a workaround with an exception to turn it on. It was found that this caused a graphics corruption issue with the Camera app. This CL is the minimal change to disable the feature by removing the samus PCI ID from the list of exceptions to the workaround which disables CMAA. BUG=642290 TEST=Bisecter reported reverting this commit resolved corruption issues. NOPRESUBMIT=true NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) |
