Use backend-specific enqueuer.

Use backend-specific enqueuer.

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/c37828c6691efb791f1b29bf95eeee012d948638

[Johnni Winther, 2016-08-31 13:04:52]

johnniwinther@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-08-31 17:45:03]

Can we merge _Enqueuer and CodegenEnqueuer?

A shared base class was useful but confusing. Now we have one subclass, it would
be less confusing to merge them.

https://codereview.chromium.org/2296153002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/enqueuer.dart (right):

https://codereview.chromium.org/2296153002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/enqueuer.dart:647: class CodegenEnqueuer extends
_Enqueuer implements enqueue.CodegenEnqueuer {
Why do we need an abstract base class that contains behaviour when we are
implementing an interface?

[sra1, 2016-08-31 17:45:47]

I'll say LGTM if you plan to merge them.

[Johnni Winther, 2016-09-01 09:01:28]

Description was changed from

==========
Use backend-specific enqueuer.
==========

to

==========
Use backend-specific enqueuer.

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c37828c6691efb791f1b29bf95eeee012d948638
==========

[Johnni Winther, 2016-09-01 09:01:29]

Committed patchset #1 (id:1) manually as
c37828c6691efb791f1b29bf95eeee012d948638 (presubmit successful).

[Johnni Winther, 2016-09-01 10:18:57]

https://codereview.chromium.org/2296153002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/enqueuer.dart (right):

https://codereview.chromium.org/2296153002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/enqueuer.dart:647: class CodegenEnqueuer extends
_Enqueuer implements enqueue.CodegenEnqueuer {
On 2016/08/31 17:45:03, sra1 wrote:
> Why do we need an abstract base class that contains behaviour when we are
> implementing an interface?

It's in the follow-up CL.