Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2296123002:
[PCv2] Remove tracing categories only needed for old TTFMP implementation (Closed)
|
Created:
4 years, 3 months ago by Kunihiko Sakamoto Modified:
4 years, 3 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org, kouhei (in TOK) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[PCv2] Remove tracing categories only needed for old TTFMP implementation
** PERF SHERRIFS: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected **
BUG=638124
Committed: https://crrev.com/b2bd8854bbbee8ccab426091a29369564710bd1a
Cr-Commit-Position: refs/heads/master@{#416115}
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== [PCv2] Remove tracing category only used in old TTFMP implementation BUG=638124 ========== to ========== [PCv2] Remove tracing category only used in old TTFMP implementation BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== [PCv2] Remove tracing category only used in old TTFMP implementation BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [PCv2] Remove tracing category only needed for old TTFMP implementation BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== [PCv2] Remove tracing category only needed for old TTFMP implementation BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
ksakamoto@chromium.org changed reviewers: + nednguyen@google.com
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
lgtm
The CQ bit was checked by nednguyen@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)
On 2016/09/01 15:24:54, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...) page_cycler_v2_site_isolation.basic_oopif is a known failure: crbug.com/641528
On 2016/09/01 15:31:15, nednguyen wrote: > On 2016/09/01 15:24:54, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...) > > page_cycler_v2_site_isolation.basic_oopif is a known failure: crbug.com/641528 Removed all CQ_EXTRA_TRYBOT since only page_cycler_v2_site_isolation.basic_oopif are failing
Description was changed from ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** THIS WILL CAUSE REGRESSION TO TimeToFirstMeaningfulPaint METRIC BUT IT's EXPECTED ** BUG=638124 ==========
The CQ bit was checked by nednguyen@google.com
Description was changed from ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** THIS WILL CAUSE REGRESSION TO TimeToFirstMeaningfulPaint METRIC BUT IT's EXPECTED ** BUG=638124 ========== to ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIF: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIF: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 ========== to ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIFS: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 ==========
Message was sent while issue was closed.
Description was changed from ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIFS: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 ========== to ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIFS: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIFS: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 ========== to ========== [PCv2] Remove tracing categories only needed for old TTFMP implementation ** PERF SHERRIFS: this will cause regression to TimeToFirstMeaningfulPaint metric but it's expected ** BUG=638124 Committed: https://crrev.com/b2bd8854bbbee8ccab426091a29369564710bd1a Cr-Commit-Position: refs/heads/master@{#416115} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b2bd8854bbbee8ccab426091a29369564710bd1a Cr-Commit-Position: refs/heads/master@{#416115} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
