Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: pkg/barback/lib/src/package_graph.dart

Issue 22961002: Add more metadata to non-programmatic barback exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Small fix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/errors.dart ('k') | pkg/barback/lib/src/phase.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/package_graph.dart
diff --git a/pkg/barback/lib/src/package_graph.dart b/pkg/barback/lib/src/package_graph.dart
index c85fdd78bbaeca6e2c867afb9b4d55cc07d0710c..307a870f19c9052ad93c6659af245cf312a919c8 100644
--- a/pkg/barback/lib/src/package_graph.dart
+++ b/pkg/barback/lib/src/package_graph.dart
@@ -52,8 +52,8 @@ class PackageGraph {
///
/// This will not emit programming errors from barback itself. Those will be
/// emitted through the [results] stream's error channel.
- Stream get errors => _errors;
- Stream _errors;
+ Stream<BarbackException> get errors => _errors;
+ Stream<BarbackException> _errors;
/// Creates a new [PackageGraph] that will transform assets in all packages
/// made available by [provider].
@@ -74,7 +74,7 @@ class PackageGraph {
// Include all build errors for all cascades. If no cascades have
// errors, the result will automatically be considered a success.
- _resultsController.add(new BuildResult(flatten(
+ _resultsController.add(new BuildResult(unionAll(
_cascadeResults.values.map((result) => result.errors))));
}, onError: _resultsController.addError);
}
« no previous file with comments | « pkg/barback/lib/src/errors.dart ('k') | pkg/barback/lib/src/phase.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698