Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: pkg/barback/lib/src/build_result.dart

Issue 22961002: Add more metadata to non-programmatic barback exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/lib/src/build_result.dart
diff --git a/pkg/barback/lib/src/build_result.dart b/pkg/barback/lib/src/build_result.dart
index 32ee7c7a217113e1feb31dc37619f6d37e9ddd3f..89ee681e34fa6518ec7fcaf44a222ede1c96146a 100644
--- a/pkg/barback/lib/src/build_result.dart
+++ b/pkg/barback/lib/src/build_result.dart
@@ -17,13 +17,13 @@ import 'utils.dart';
/// although individual assets may still have built successfully.
class BuildResult {
/// All errors that occurred during the build.
- final List errors;
+ final Set<BarbackException> errors;
Bob Nystrom 2013/08/13 00:04:29 Is there a reason to not make it a list and preser
nweiz 2013/08/13 19:15:11 The errors from different cascades all get merged
/// `true` if the build succeeded.
bool get succeeded => errors.isEmpty;
- BuildResult(Iterable errors)
- : errors = errors.toList();
+ BuildResult(Iterable<BarbackException> errors)
+ : errors = errors.toSet();
/// Creates a build result indicating a successful build.
///

Powered by Google App Engine
This is Rietveld 408576698