Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2296063003: MD Settings: Internet: Minor html cleanup (Closed)

Created:
4 years, 3 months ago by stevenjb
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Minor html cleanup This is laregly prep work to make the next set of diffs reasonable. There should be no siginficante visual changes. BUG=609156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7a55aef2f749a19d39190b58ba6f5c6acdadb6f5 Cr-Commit-Position: refs/heads/master@{#416301}

Patch Set 1 #

Patch Set 2 : Add missing css #

Total comments: 2

Patch Set 3 : Rebase, fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -70 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 2 4 chunks +77 lines, -63 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_shared_css.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
stevenjb
Mostly this changes a bunch of indentation. I separated that out to make the diff ...
4 years, 3 months ago (2016-08-31 22:11:01 UTC) #3
dschuyler
lgtm https://codereview.chromium.org/2296063003/diff/20001/chrome/browser/resources/settings/internet_page/internet_detail_page.html File chrome/browser/resources/settings/internet_page/internet_detail_page.html (right): https://codereview.chromium.org/2296063003/diff/20001/chrome/browser/resources/settings/internet_page/internet_detail_page.html#newcode137 chrome/browser/resources/settings/internet_page/internet_detail_page.html:137: disabled="[[isNetworkPolicyEnforced(networkProperties.Priority)]]"> nit: wrap line or indent less.
4 years, 3 months ago (2016-09-01 20:45:13 UTC) #4
stevenjb
https://codereview.chromium.org/2296063003/diff/20001/chrome/browser/resources/settings/internet_page/internet_detail_page.html File chrome/browser/resources/settings/internet_page/internet_detail_page.html (right): https://codereview.chromium.org/2296063003/diff/20001/chrome/browser/resources/settings/internet_page/internet_detail_page.html#newcode137 chrome/browser/resources/settings/internet_page/internet_detail_page.html:137: disabled="[[isNetworkPolicyEnforced(networkProperties.Priority)]]"> On 2016/09/01 20:45:13, dschuyler wrote: > nit: wrap ...
4 years, 3 months ago (2016-09-02 17:07:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296063003/40001
4 years, 3 months ago (2016-09-02 17:09:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 18:18:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:20:52 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a55aef2f749a19d39190b58ba6f5c6acdadb6f5
Cr-Commit-Position: refs/heads/master@{#416301}

Powered by Google App Engine
This is Rietveld 408576698