Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2296063002: Desktop Capture Picker Window String Change (Closed)

Created:
4 years, 3 months ago by qiangchen
Modified:
4 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Desktop Capture Picker Window String Change In the major CL, I did not notice the designed actually changed the statement a little, namely "would like" was changed to "wants" This CL fix this. BUG=602478, 642778 Committed: https://crrev.com/2b4bb81ea09b9e553a1721ee04da67b5b61dd62c Cr-Commit-Position: refs/heads/master@{#415746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
qiangchen
UI Designer points out a string change I missed in the development. A very small ...
4 years, 3 months ago (2016-08-31 16:36:19 UTC) #8
msw
lgtm
4 years, 3 months ago (2016-08-31 20:40:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296063002/1
4 years, 3 months ago (2016-08-31 20:42:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:47:26 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:50:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b4bb81ea09b9e553a1721ee04da67b5b61dd62c
Cr-Commit-Position: refs/heads/master@{#415746}

Powered by Google App Engine
This is Rietveld 408576698