Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2296053004: Revert of Remove gyp-win-tool. (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove gyp-win-tool. (patchset #1 id:1 of https://codereview.chromium.org/2301193002/ ) Reason for revert: Build broken with change: https://build.chromium.org/p/chromium/builders/Win/builds/46673 Original issue's description: > Remove gyp-win-tool. > > Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory. > > BUG=642014 > > Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165 > Cr-Commit-Position: refs/heads/master@{#416052} TBR=scottmg@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642014 Committed: https://crrev.com/60020274bacd81b0b4b091405e363ee56d407a42 Cr-Commit-Position: refs/heads/master@{#416070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M build/toolchain/win/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M build/toolchain/win/setup_toolchain.py View 2 chunks +39 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fgorski
Created Revert of Remove gyp-win-tool.
4 years, 3 months ago (2016-09-01 21:47:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296053004/1
4 years, 3 months ago (2016-09-01 21:47:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 21:49:16 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:52:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60020274bacd81b0b4b091405e363ee56d407a42
Cr-Commit-Position: refs/heads/master@{#416070}

Powered by Google App Engine
This is Rietveld 408576698