Don't call TestingBrowserProcess::CreateInstance() twice in metrics_reporting_handler_unittest

Don't call TestingBrowserProcess::CreateInstance() twice in metrics_reporting_handler_unittest

Also initialized very early at https://cs.chromium.org/chromium/src/chrome/test/base/chrome_unit_test_suite.cc?q=TestingBrowserProcess::CreateInstance()&sq=package:chromium&l=53&dr=C but I think the double init isn't noticed because it'd only be in GOOGLE_CHROME_BUILD and Debug.

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's unrelated.

TBR=dbeam@chromium.org
BUG=510836
Committed: https://crrev.com/254b091934f038454141930b8270a6987fb014ec
Cr-Commit-Position: refs/heads/master@{#415501}

[Dan Beam, 2016-08-30 23:01:47]

lgtm

[scottmg, 2016-08-30 23:01:52]

Description was changed from

==========
Don't call TestingBrowserProcess::CreateInstance() twice in
metrics_reporting_handler_unittest

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's
unrelated.

TBR=dbeam@chromium.org
BUG=510836
==========

to

==========
Don't call TestingBrowserProcess::CreateInstance() twice in
metrics_reporting_handler_unittest

Also initialized very early at
https://cs.chromium.org/chromium/src/chrome/test/base/chrome_unit_test_suite....
but I think the double init isn't noticed because it'd only be in
GOOGLE_CHROME_BUILD and Debug.

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's
unrelated.

TBR=dbeam@chromium.org
BUG=510836
==========

[scottmg, 2016-08-30 23:01:56]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:58:43]

Description was changed from

==========
Don't call TestingBrowserProcess::CreateInstance() twice in
metrics_reporting_handler_unittest

Also initialized very early at
https://cs.chromium.org/chromium/src/chrome/test/base/chrome_unit_test_suite....
but I think the double init isn't noticed because it'd only be in
GOOGLE_CHROME_BUILD and Debug.

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's
unrelated.

TBR=dbeam@chromium.org
BUG=510836
==========

to

==========
Don't call TestingBrowserProcess::CreateInstance() twice in
metrics_reporting_handler_unittest

Also initialized very early at
https://cs.chromium.org/chromium/src/chrome/test/base/chrome_unit_test_suite....
but I think the double init isn't noticed because it'd only be in
GOOGLE_CHROME_BUILD and Debug.

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's
unrelated.

TBR=dbeam@chromium.org
BUG=510836
==========

[commit-bot: I haz the power, 2016-08-30 23:58:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 00:02:55]

Description was changed from

==========
Don't call TestingBrowserProcess::CreateInstance() twice in
metrics_reporting_handler_unittest

Also initialized very early at
https://cs.chromium.org/chromium/src/chrome/test/base/chrome_unit_test_suite....
but I think the double init isn't noticed because it'd only be in
GOOGLE_CHROME_BUILD and Debug.

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's
unrelated.

TBR=dbeam@chromium.org
BUG=510836
==========

to

==========
Don't call TestingBrowserProcess::CreateInstance() twice in
metrics_reporting_handler_unittest

Also initialized very early at
https://cs.chromium.org/chromium/src/chrome/test/base/chrome_unit_test_suite....
but I think the double init isn't noticed because it'd only be in
GOOGLE_CHROME_BUILD and Debug.

Reviewed at https://codereview.chromium.org/2297863003/ but split out since it's
unrelated.

TBR=dbeam@chromium.org
BUG=510836

Committed: https://crrev.com/254b091934f038454141930b8270a6987fb014ec
Cr-Commit-Position: refs/heads/master@{#415501}
==========

[commit-bot: I haz the power, 2016-08-31 00:02:56]

Patchset 1 (id:??) landed as
https://crrev.com/254b091934f038454141930b8270a6987fb014ec
Cr-Commit-Position: refs/heads/master@{#415501}