components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc - Issue 2296043003: Rename Lo-Fi previews to lite pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc

Issue 2296043003: Rename Lo-Fi previews to lite pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddTests

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h ('k') | components/data_reduction_proxy/core/common/lofi_decider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc

index dc65c52936346ef05d97ec9a3e92add96df2feca..641c011d444891db0e5ce350e43ccc63018a0a72 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc

@@ -79,11 +79,11 @@ const char kEnableDataReductionProxyBypassWarning[] =

const char kEnableDataReductionProxyCarrierTest[] =

"enable-data-reduction-proxy-carrier-test";

-// Enables preview mode for Lo-Fi. This means a preview should be requested

-// instead of placeholders whenever Lo-Fi mode is on. Lo-Fi must also be enabled

-// via a flag or field trial.

-const char kEnableDataReductionProxyLoFiPreview[] =

- "enable-data-reduction-proxy-lo-fi-preview";

+// Enables lite page previews from the data reduction proxy. This means a

+// lite page should be requested instead of placeholders whenever Lo-Fi mode is

+// on. Lo-Fi must also be enabled via a flag or field trial.

+const char kEnableDataReductionProxyLitePage[] =

+ "enable-data-reduction-proxy-lite-page";

bengr 2016/09/22 22:04:48 Please fix all integration tests along with this c

tbansal1 2016/09/23 00:08:41 nit: you will also need to update the field trial

megjablon 2016/09/27 00:08:11 Done.

// Enables sending a pageload metrics pingback after every page load.

const char kEnableDataReductionProxyForcePingback[] =