tools/chrome_proxy/common/chrome_proxy_metrics.py - Issue 2296043003: Rename Lo-Fi previews to lite pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/common/chrome_proxy_metrics.py

Issue 2296043003: Rename Lo-Fi previews to lite pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddTests

Patch Set: tbansal comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/common/lofi_decider.h ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/common/chrome_proxy_metrics.py

diff --git a/tools/chrome_proxy/common/chrome_proxy_metrics.py b/tools/chrome_proxy/common/chrome_proxy_metrics.py

index 47a6d6b0673141dd3b27fef2995deaecc56f6a3a..92596dae6874764cf2c38a129be82c521f73ec02 100644

--- a/tools/chrome_proxy/common/chrome_proxy_metrics.py

+++ b/tools/chrome_proxy/common/chrome_proxy_metrics.py

@@ -103,13 +103,13 @@ class ChromeProxyResponse(network_metrics.HTTPResponse):

def HasChromeProxyLoFiResponse(self):

return self.HasResponseHeader('Chrome-Proxy', "q=low")

- def HasChromeProxyLoFiPreviewRequest(self):

+ def HasChromeProxyLitePageRequest(self):

return self.HasRequestHeader('Chrome-Proxy', "q=preview")

- def HasChromeProxyLoFiPreviewExpRequest(self):

+ def HasChromeProxyLitePageExpRequest(self):

return self.HasRequestHeader('Chrome-Proxy', "exp=ignore_preview_blacklist")

- def HasChromeProxyLoFiPreviewResponse(self):

+ def HasChromeProxyLitePageResponse(self):

return self.HasResponseHeader('Chrome-Proxy', "q=preview")

def HasChromeProxyPassThroughRequest(self):