Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2296033002: Only use gcc_compile_wrapper when resource whitelisting is enabled. (Closed)

Created:
4 years, 3 months ago by estevenson
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, Nico, agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only use gcc_compile_wrapper when resource whitelisting is enabled. Using gcc_compile_wrapper.py unconditionally is inefficient and makes debugging more difficult. This is problematic since resource whitelisting occurs relatively infrequently. BUG=642498 Committed: https://crrev.com/3b7fbab033063d07967e8fd9d084a53eb5d05edc Cr-Commit-Position: refs/heads/master@{#415624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M build/toolchain/gcc_toolchain.gni View 3 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
estevenson
ptal!
4 years, 3 months ago (2016-08-30 23:35:59 UTC) #4
agrieve
On 2016/08/30 23:35:59, estevenson wrote: > ptal! lgtm
4 years, 3 months ago (2016-08-31 00:13:49 UTC) #5
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-31 04:38:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296033002/1
4 years, 3 months ago (2016-08-31 13:53:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 13:57:51 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b7fbab033063d07967e8fd9d084a53eb5d05edc Cr-Commit-Position: refs/heads/master@{#415624}
4 years, 3 months ago (2016-08-31 13:59:47 UTC) #13
Nico
4 years, 3 months ago (2016-08-31 14:13:43 UTC) #15
Message was sent while issue was closed.
Thanks! :-)

Powered by Google App Engine
This is Rietveld 408576698